Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 804353003: Revert of Refactor Vaapi video decoder/encoder in preparation of Freon support (Closed)

Created:
6 years ago by dcheng
Modified:
6 years ago
CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Refactor Vaapi video decoder/encoder in preparation of Freon support (patchset #6 id:100001 of https://codereview.chromium.org/807853005/) Reason for revert: Caused build failure on Linux ChromiumOS GN: ninja: error: '../../content/common/content/common/gpu/media/va_x11.sigs', needed by 'obj/content/common/libva_generate_stubs.inputdeps.stamp', missing and no known rule to make it Original issue's description: > Refactor Vaapi video decoder/encoder in preparation of Freon support > > This introduces VaapiPicture which abstracts the output picture for the VaapiVideoDecodeAccelerator. > This also splits out the x11 specific functions of LibVA into their own signature file. > And finally this adds back GLImageGLX to match the code path that will be used on Freon, using GLImageLinuxDMABuffer. > > BUG=403058 > TEST=video_decode_accelerator_unittest and video_encode_accelerator_unittest > > Committed: https://crrev.com/289e96375e75be0d9158b86df2bd4faf2d7b2a64 > Cr-Commit-Position: refs/heads/master@{#309355} TBR=reveman@chromium.org,posciak@chromium.org,scherkus@chromium.org,piman@chromium.org,lionel.g.landwerlin@intel.com NOTREECHECKS=true NOTRY=true BUG=403058 Committed: https://crrev.com/6dc14e495d4ca089c096ba0263fd5269647de838 Cr-Commit-Position: refs/heads/master@{#309356}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+431 lines, -498 lines) Patch
M content/common/BUILD.gn View 5 chunks +4 lines, -16 lines 0 comments Download
M content/common/gpu/media/gpu_video_decode_accelerator.cc View 2 chunks +13 lines, -4 lines 0 comments Download
M content/common/gpu/media/gpu_video_encode_accelerator.cc View 2 chunks +7 lines, -6 lines 0 comments Download
M content/common/gpu/media/rendering_helper.h View 1 chunk +1 line, -4 lines 0 comments Download
M content/common/gpu/media/rendering_helper.cc View 10 chunks +17 lines, -22 lines 0 comments Download
M content/common/gpu/media/va.sigs View 1 chunk +7 lines, -0 lines 0 comments Download
M content/common/gpu/media/va_surface.h View 4 chunks +4 lines, -13 lines 0 comments Download
D content/common/gpu/media/va_x11.sigs View 1 chunk +0 lines, -9 lines 0 comments Download
M content/common/gpu/media/vaapi_h264_decoder_unittest.cc View 3 chunks +23 lines, -7 lines 0 comments Download
D content/common/gpu/media/vaapi_picture.h View 1 chunk +0 lines, -73 lines 0 comments Download
D content/common/gpu/media/vaapi_picture.cc View 1 chunk +0 lines, -40 lines 0 comments Download
D content/common/gpu/media/vaapi_tfp_picture.h View 1 chunk +0 lines, -56 lines 0 comments Download
D content/common/gpu/media/vaapi_tfp_picture.cc View 1 chunk +0 lines, -77 lines 0 comments Download
M content/common/gpu/media/vaapi_video_decode_accelerator.h View 8 chunks +22 lines, -16 lines 0 comments Download
M content/common/gpu/media/vaapi_video_decode_accelerator.cc View 14 chunks +231 lines, -39 lines 0 comments Download
M content/common/gpu/media/vaapi_video_encode_accelerator.h View 3 chunks +4 lines, -2 lines 0 comments Download
M content/common/gpu/media/vaapi_video_encode_accelerator.cc View 4 chunks +10 lines, -7 lines 0 comments Download
M content/common/gpu/media/vaapi_wrapper.h View 7 chunks +20 lines, -21 lines 0 comments Download
M content/common/gpu/media/vaapi_wrapper.cc View 9 chunks +45 lines, -52 lines 0 comments Download
M content/common/gpu/media/video_decode_accelerator_unittest.cc View 2 chunks +12 lines, -4 lines 0 comments Download
M content/common/gpu/media/video_encode_accelerator_unittest.cc View 2 chunks +7 lines, -3 lines 0 comments Download
M content/content_common.gypi View 3 chunks +2 lines, -23 lines 0 comments Download
M media/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M media/media.gyp View 1 chunk +1 line, -1 line 0 comments Download
M ui/gl/gl_image_glx.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
dcheng
Created Revert of Refactor Vaapi video decoder/encoder in preparation of Freon support
6 years ago (2014-12-20 18:49:44 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/804353003/1
6 years ago (2014-12-20 18:50:42 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-20 18:51:38 UTC) #3
commit-bot: I haz the power
6 years ago (2014-12-20 18:52:15 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6dc14e495d4ca089c096ba0263fd5269647de838
Cr-Commit-Position: refs/heads/master@{#309356}

Powered by Google App Engine
This is Rietveld 408576698