Issue 804253005: XFA: Fix GN build under chromium checkout.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 804253005: XFA: Fix GN build under chromium checkout. (Closed)

Created:
5 years, 11 months ago by Tom Sepez

Modified:
5 years, 11 months ago

Reviewers:
Lei Zhang, brucedawson

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa

Target Ref:
refs/heads/xfa

Visibility:
Public.

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -5 lines)			Patch
	M	third_party/BUILD.gn	View	1	3 chunks	+14 lines, -5 lines	0 comments	Download

Total messages: 6 (1 generated)

brucedawson

I'm afraid I haven't done anything with BUILD.gn files yet so I really can't usefully ...

5 years, 11 months ago (2015-01-09 22:30:10 UTC) #3

Lei Zhang

We already did this on the main branch. You should just merge that CL over: ...

5 years, 11 months ago (2015-01-09 22:34:52 UTC) #4

Tom Sepez

On 2015/01/09 22:34:52, Lei Zhang wrote: > We already did this on the main branch. ...

5 years, 11 months ago (2015-01-09 22:48:10 UTC) #5

Tom Sepez

5 years, 11 months ago (2015-01-09 22:49:51 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
541726611d9e66f7bc790e6477c0507db0a07d9e (presubmit successful).