Issue 817813004: Fix new third_party/BUILD.gn to use the right build configuration.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 817813004: Fix new third_party/BUILD.gn to use the right build configuration. (Closed)

Created:
6 years ago by Lei Zhang

Modified:
5 years, 11 months ago

Reviewers:
Tom Sepez

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Fix new third_party/BUILD.gn to use the right build configuration. TBR=tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/59dffb68f07c7ce583285a23ad580b768ce3cd3e

Patch Set 1 #

Total comments: 1

Created: 6 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -5 lines)			Patch
	M	third_party/BUILD.gn	View		3 chunks	+14 lines, -5 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Lei Zhang

Committed patchset #1 (id:1) manually as 59dffb68f07c7ce583285a23ad580b768ce3cd3e (presubmit successful).

6 years ago (2014-12-20 05:21:38 UTC) #2

Tom Sepez

5 years, 11 months ago (2015-01-09 22:53:01 UTC) #3

Message was sent while issue was closed.

https://codereview.chromium.org/817813004/diff/1/third_party/BUILD.gn
File third_party/BUILD.gn (right):

https://codereview.chromium.org/817813004/diff/1/third_party/BUILD.gn#newcode16
third_party/BUILD.gn:16: "//third_party/pdfium:pdfium_config",
Not sure how this plays out in a standalone world (GN not yet supported there)
where the top level directory is not under third_party ...

Expand Messages | Collapse Messages