Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 804133003: skimage, die die die (Closed)

Created:
6 years ago by mtklein_C
Modified:
6 years ago
Reviewers:
scroggo, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

skimage, die die die DM's running with --images on all the bots now. They look happy. BUG=skia:3235 Committed: https://skia.googlesource.com/skia/+/9a0d6d6c88b87b3d0195e5633403325b6e922b8c

Patch Set 1 #

Patch Set 2 : Expectations too #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -24309 lines) Patch
D expectations/skimage/Test-Android-GalaxyS4-SGX544-Arm7-Debug/expected-results.json View 1 1 chunk +0 lines, -784 lines 0 comments Download
D expectations/skimage/Test-Android-GalaxyS4-SGX544-Arm7-Release/expected-results.json View 1 1 chunk +0 lines, -784 lines 0 comments Download
D expectations/skimage/Test-Android-Logan-Nvidia-Arm7-Debug/expected-results.json View 1 1 chunk +0 lines, -4 lines 0 comments Download
D expectations/skimage/Test-Android-Logan-Nvidia-Arm7-Release/expected-results.json View 1 1 chunk +0 lines, -4 lines 0 comments Download
D expectations/skimage/Test-Android-Nexus10-MaliT604-Arm7-Debug/expected-results.json View 1 1 chunk +0 lines, -784 lines 0 comments Download
D expectations/skimage/Test-Android-Nexus10-MaliT604-Arm7-Release-Recipes/expected-results.json View 1 1 chunk +0 lines, -784 lines 0 comments Download
D expectations/skimage/Test-Android-Nexus10-MaliT604-Arm7-Release/expected-results.json View 1 1 chunk +0 lines, -784 lines 0 comments Download
D expectations/skimage/Test-Android-Nexus4-Adreno320-Arm7-Debug/expected-results.json View 1 1 chunk +0 lines, -784 lines 0 comments Download
D expectations/skimage/Test-Android-Nexus4-Adreno320-Arm7-Release/expected-results.json View 1 1 chunk +0 lines, -784 lines 0 comments Download
D expectations/skimage/Test-Android-Nexus5-Adreno330-Arm7-Debug/expected-results.json View 1 1 chunk +0 lines, -784 lines 0 comments Download
D expectations/skimage/Test-Android-Nexus5-Adreno330-Arm7-Release/expected-results.json View 1 1 chunk +0 lines, -784 lines 0 comments Download
D expectations/skimage/Test-Android-Nexus7-Tegra3-Arm7-Debug/expected-results.json View 1 1 chunk +0 lines, -784 lines 0 comments Download
D expectations/skimage/Test-Android-Nexus7-Tegra3-Arm7-Release/expected-results.json View 1 1 chunk +0 lines, -784 lines 0 comments Download
D expectations/skimage/Test-Android-Nexus9-TegraK1-Arm64-Debug/expected-results.json View 1 1 chunk +0 lines, -784 lines 0 comments Download
D expectations/skimage/Test-Android-Nexus9-TegraK1-Arm64-Release/expected-results.json View 1 1 chunk +0 lines, -784 lines 0 comments Download
D expectations/skimage/Test-Android-NexusPlayer-PowerVR-x86-Debug/expected-results.json View 1 1 chunk +0 lines, -784 lines 0 comments Download
D expectations/skimage/Test-Android-NexusPlayer-PowerVR-x86-Release/expected-results.json View 1 1 chunk +0 lines, -4 lines 0 comments Download
D expectations/skimage/Test-Android-Xoom-Tegra2-Arm7-Debug/expected-results.json View 1 1 chunk +0 lines, -712 lines 0 comments Download
D expectations/skimage/Test-Android-Xoom-Tegra2-Arm7-Release/expected-results.json View 1 1 chunk +0 lines, -712 lines 0 comments Download
D expectations/skimage/Test-ChromeOS-Alex-GMA3150-x86-Debug/expected-results.json View 1 1 chunk +0 lines, -214 lines 0 comments Download
D expectations/skimage/Test-ChromeOS-Alex-GMA3150-x86-Release/expected-results.json View 1 1 chunk +0 lines, -214 lines 0 comments Download
D expectations/skimage/Test-ChromeOS-Daisy-MaliT604-Arm7-Debug/expected-results.json View 1 1 chunk +0 lines, -214 lines 0 comments Download
D expectations/skimage/Test-ChromeOS-Daisy-MaliT604-Arm7-Release/expected-results.json View 1 1 chunk +0 lines, -214 lines 0 comments Download
D expectations/skimage/Test-ChromeOS-Link-HD4000-x86_64-Debug-Recipes/expected-results.json View 1 1 chunk +0 lines, -214 lines 0 comments Download
D expectations/skimage/Test-ChromeOS-Link-HD4000-x86_64-Debug/expected-results.json View 1 1 chunk +0 lines, -214 lines 0 comments Download
D expectations/skimage/Test-ChromeOS-Link-HD4000-x86_64-Release/expected-results.json View 1 1 chunk +0 lines, -214 lines 0 comments Download
D expectations/skimage/Test-Linux-Bare-NoGPU-Arm8_64-Debug/expected-results.json View 1 1 chunk +0 lines, -214 lines 0 comments Download
D expectations/skimage/Test-Mac10.6-MacMini4.1-GeForce320M-x86-Debug/expected-results.json View 1 1 chunk +0 lines, -214 lines 0 comments Download
D expectations/skimage/Test-Mac10.6-MacMini4.1-GeForce320M-x86-Release/expected-results.json View 1 1 chunk +0 lines, -214 lines 0 comments Download
D expectations/skimage/Test-Mac10.6-MacMini4.1-GeForce320M-x86_64-Debug/expected-results.json View 1 1 chunk +0 lines, -214 lines 0 comments Download
D expectations/skimage/Test-Mac10.6-MacMini4.1-GeForce320M-x86_64-Release/expected-results.json View 1 1 chunk +0 lines, -214 lines 0 comments Download
D expectations/skimage/Test-Mac10.7-MacMini4.1-GeForce320M-x86-Debug/expected-results.json View 1 1 chunk +0 lines, -214 lines 0 comments Download
D expectations/skimage/Test-Mac10.7-MacMini4.1-GeForce320M-x86-Release/expected-results.json View 1 1 chunk +0 lines, -214 lines 0 comments Download
D expectations/skimage/Test-Mac10.7-MacMini4.1-GeForce320M-x86_64-Debug/expected-results.json View 1 1 chunk +0 lines, -214 lines 0 comments Download
D expectations/skimage/Test-Mac10.7-MacMini4.1-GeForce320M-x86_64-Release/expected-results.json View 1 1 chunk +0 lines, -214 lines 0 comments Download
D expectations/skimage/Test-Mac10.8-MacMini4.1-GeForce320M-x86-Debug/expected-results.json View 1 1 chunk +0 lines, -214 lines 0 comments Download
D expectations/skimage/Test-Mac10.8-MacMini4.1-GeForce320M-x86-Release/expected-results.json View 1 1 chunk +0 lines, -214 lines 0 comments Download
D expectations/skimage/Test-Mac10.8-MacMini4.1-GeForce320M-x86_64-Debug/expected-results.json View 1 1 chunk +0 lines, -214 lines 0 comments Download
D expectations/skimage/Test-Mac10.8-MacMini4.1-GeForce320M-x86_64-Release/expected-results.json View 1 1 chunk +0 lines, -214 lines 0 comments Download
D expectations/skimage/Test-Mac10.9-MacMini6.2-HD4000-x86_64-Debug/expected-results.json View 1 1 chunk +0 lines, -214 lines 0 comments Download
D expectations/skimage/Test-Mac10.9-MacMini6.2-HD4000-x86_64-Release/expected-results.json View 1 1 chunk +0 lines, -214 lines 0 comments Download
D expectations/skimage/Test-Ubuntu12-ShuttleA-GTX550Ti-x86_64-Release-Valgrind/expected-results.json View 1 1 chunk +0 lines, -214 lines 0 comments Download
D expectations/skimage/Test-Ubuntu12-ShuttleA-GTX660-x86-Debug/expected-results.json View 1 1 chunk +0 lines, -214 lines 0 comments Download
D expectations/skimage/Test-Ubuntu12-ShuttleA-GTX660-x86-Release/expected-results.json View 1 1 chunk +0 lines, -214 lines 0 comments Download
D expectations/skimage/Test-Ubuntu12-ShuttleA-GTX660-x86_64-Debug/expected-results.json View 1 1 chunk +0 lines, -214 lines 0 comments Download
D expectations/skimage/Test-Ubuntu12-ShuttleA-GTX660-x86_64-Release/expected-results.json View 1 1 chunk +0 lines, -214 lines 0 comments Download
D expectations/skimage/Test-Ubuntu12-ShuttleA-HD2000-x86_64-Release-Valgrind/expected-results.json View 1 1 chunk +0 lines, -214 lines 0 comments Download
D expectations/skimage/Test-Ubuntu13.10-GCE-NoGPU-x86_64-Debug-ASAN/expected-results.json View 1 1 chunk +0 lines, -214 lines 0 comments Download
D expectations/skimage/Test-Ubuntu13.10-GCE-NoGPU-x86_64-Debug-UBSAN/expected-results.json View 1 1 chunk +0 lines, -214 lines 0 comments Download
D expectations/skimage/Test-Ubuntu13.10-GCE-NoGPU-x86_64-Debug/expected-results.json View 1 1 chunk +0 lines, -214 lines 0 comments Download
D expectations/skimage/Test-Ubuntu13.10-GCE-NoGPU-x86_64-Release-Shared/expected-results.json View 1 1 chunk +0 lines, -214 lines 0 comments Download
D expectations/skimage/Test-Ubuntu13.10-ShuttleA-NoGPU-x86_64-Debug-Recipes/expected-results.json View 1 1 chunk +0 lines, -214 lines 0 comments Download
D expectations/skimage/Test-Win7-ShuttleA-HD2000-x86-Debug-ANGLE/expected-results.json View 1 1 chunk +0 lines, -214 lines 0 comments Download
D expectations/skimage/Test-Win7-ShuttleA-HD2000-x86-Debug-GDI/expected-results.json View 1 1 chunk +0 lines, -214 lines 0 comments Download
D expectations/skimage/Test-Win7-ShuttleA-HD2000-x86-Debug/expected-results.json View 1 1 chunk +0 lines, -214 lines 0 comments Download
D expectations/skimage/Test-Win7-ShuttleA-HD2000-x86-Release-ANGLE/expected-results.json View 1 1 chunk +0 lines, -214 lines 0 comments Download
D expectations/skimage/Test-Win7-ShuttleA-HD2000-x86-Release-GDI/expected-results.json View 1 1 chunk +0 lines, -214 lines 0 comments Download
D expectations/skimage/Test-Win7-ShuttleA-HD2000-x86-Release/expected-results.json View 1 1 chunk +0 lines, -214 lines 0 comments Download
D expectations/skimage/Test-Win7-ShuttleA-HD2000-x86_64-Debug/expected-results.json View 1 1 chunk +0 lines, -214 lines 0 comments Download
D expectations/skimage/Test-Win7-ShuttleA-HD2000-x86_64-Release/expected-results.json View 1 1 chunk +0 lines, -214 lines 0 comments Download
D expectations/skimage/Test-Win8-ShuttleA-GTX660-x86-Debug/expected-results.json View 1 1 chunk +0 lines, -214 lines 0 comments Download
D expectations/skimage/Test-Win8-ShuttleA-GTX660-x86-Release-NVPR/expected-results.json View 1 1 chunk +0 lines, -214 lines 0 comments Download
D expectations/skimage/Test-Win8-ShuttleA-GTX660-x86-Release/expected-results.json View 1 1 chunk +0 lines, -214 lines 0 comments Download
D expectations/skimage/Test-Win8-ShuttleA-GTX660-x86_64-Debug/expected-results.json View 1 1 chunk +0 lines, -214 lines 0 comments Download
D expectations/skimage/Test-Win8-ShuttleA-GTX660-x86_64-Release/expected-results.json View 1 1 chunk +0 lines, -214 lines 0 comments Download
D expectations/skimage/Test-Win8-ShuttleA-HD7770-x86-Debug/expected-results.json View 1 1 chunk +0 lines, -214 lines 0 comments Download
D expectations/skimage/Test-Win8-ShuttleA-HD7770-x86-Release/expected-results.json View 1 1 chunk +0 lines, -214 lines 0 comments Download
D expectations/skimage/Test-Win8-ShuttleA-HD7770-x86_64-Debug/expected-results.json View 1 1 chunk +0 lines, -214 lines 0 comments Download
D expectations/skimage/Test-Win8-ShuttleA-HD7770-x86_64-Release/expected-results.json View 1 1 chunk +0 lines, -214 lines 0 comments Download
M gm/gm_json.py View 1 chunk +0 lines, -6 lines 0 comments Download
M gyp/tools.gyp View 3 chunks +1 line, -20 lines 0 comments Download
M tools/picture_utils.h View 1 chunk +0 lines, -4 lines 0 comments Download
D tools/skimage_main.cpp View 1 chunk +0 lines, -845 lines 0 comments Download
M tools/test_all.py View 1 chunk +0 lines, -7 lines 0 comments Download
D tools/tests/skimage/.gitignore View 1 chunk +0 lines, -2 lines 0 comments Download
D tools/tests/skimage/input/README View 1 chunk +0 lines, -1 line 0 comments Download
D tools/tests/skimage/input/bad-images/empty-results.json View 1 chunk +0 lines, -12 lines 0 comments Download
D tools/tests/skimage/input/bad-images/ignore-results.json View 1 chunk +0 lines, -16 lines 0 comments Download
D tools/tests/skimage/input/bad-images/incorrect-results.json View 1 chunk +0 lines, -16 lines 0 comments Download
D tools/tests/skimage/input/bad-images/invalid.png View 1 Binary file 0 comments Download
D tools/tests/skimage/input/images-with-known-hashes/1209453360120438698.png View Binary file 0 comments Download
D tools/tests/skimage/input/images-with-known-hashes/12927999507540085554.png View Binary file 0 comments Download
D tools/tests/skimage/input/images-with-known-hashes/ignore-failures.json View 1 chunk +0 lines, -16 lines 0 comments Download
D tools/tests/skimage/input/images-with-known-hashes/incorrect-results.json View 1 chunk +0 lines, -16 lines 0 comments Download
D tools/tests/skimage/output-actual/README View 1 chunk +0 lines, -1 line 0 comments Download
D tools/tests/skimage/output-actual/create-expectations/README View 1 chunk +0 lines, -2 lines 0 comments Download
D tools/tests/skimage/output-actual/empty-dir/README View 1 chunk +0 lines, -1 line 0 comments Download
D tools/tests/skimage/output-actual/nonexistent-dir/README View 1 chunk +0 lines, -1 line 0 comments Download
D tools/tests/skimage/output-expected/README View 1 chunk +0 lines, -1 line 0 comments Download
D tools/tests/skimage/output-expected/create-expectations/expectations.json View 1 chunk +0 lines, -22 lines 0 comments Download
D tools/tests/skimage/output-expected/empty-dir/expectations.json View 1 chunk +0 lines, -9 lines 0 comments Download
D tools/tests/skimage/output-expected/nonexistent-dir/expectations.json View 1 chunk +0 lines, -9 lines 0 comments Download
D tools/tests/skimage_self_test.py View 1 chunk +0 lines, -190 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
mtklein
6 years ago (2014-12-15 20:19:11 UTC) #2
scroggo
On 2014/12/15 20:19:11, mtklein wrote: LGTM
6 years ago (2014-12-15 20:33:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/804133003/20001
6 years ago (2014-12-15 20:35:23 UTC) #5
commit-bot: I haz the power
6 years ago (2014-12-15 20:47:56 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/9a0d6d6c88b87b3d0195e5633403325b6e922b8c

Powered by Google App Engine
This is Rietveld 408576698