tools/picture_utils.h - Issue 804133003: skimage, die die die

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/picture_utils.h

Issue 804133003: skimage, die die die (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Expectations too Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/picture_utils.h

diff --git a/tools/picture_utils.h b/tools/picture_utils.h

index a5fcf7c96898cdcc178849025d2d98a4f5481639..b72f9d7b41aa12f3cbda4378a72151ebc64af1a5 100644

--- a/tools/picture_utils.h

+++ b/tools/picture_utils.h

@@ -22,10 +22,6 @@ namespace sk_tools {

/**

* Replaces all instances of oldChar with newChar in str.

- *

- * TODO: This function appears here and in skimage_main.cpp ;

- * we should add the implementation to src/core/SkString.cpp, write tests for it,

- * and remove it from elsewhere.

void replace_char(SkString* str, const char oldChar, const char newChar);

« no previous file with comments | « gyp/tools.gyp ('k') | tools/skimage_main.cpp » ('j') | no next file with comments »