Issue 804013005: [bindings] Use Local<> in lieu of Handle<> for the union.h/cpp in templates.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 804013005: [bindings] Use Local<> in lieu of Handle<> for the union.h/cpp in templates. (Closed)

Created:
6 years ago by vivekg_samsung

Modified:
6 years ago

Reviewers:
haraken, vivekg

CC:
arv+blink, blink-reviews, blink-reviews-bindings_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

[bindings] Use Local<> in lieu of Handle<> for the union.h/cpp in templates. Generated code should make use of Local<> in place of Handle<>. Making the change in the union.h/cpp. BUG=424445 R=haraken@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187234

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+112 lines, -112 lines)			Patch
M	Source/bindings/templates/union.h	View	2 chunks	+5 lines, -5 lines	0 comments	Download
M	Source/bindings/templates/union.cpp	View	4 chunks	+5 lines, -5 lines	0 comments	Download
M	Source/bindings/tests/results/core/UnionTypesCore.h	View	22 chunks	+45 lines, -45 lines	0 comments	Download
M	Source/bindings/tests/results/core/UnionTypesCore.cpp	View	33 chunks	+57 lines, -57 lines	0 comments	Download

Total messages: 6 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/804013005/1

6 years ago (2014-12-16 08:01:35 UTC) #5

commit-bot: I haz the power

6 years ago (2014-12-16 08:39:57 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=187234