Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Unified Diff: Source/bindings/templates/union.h

Issue 804013005: [bindings] Use Local<> in lieu of Handle<> for the union.h/cpp in templates. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/bindings/templates/union.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/templates/union.h
diff --git a/Source/bindings/templates/union.h b/Source/bindings/templates/union.h
index d01f1b18eca553497e4b29f3b1f3b7c4be43c2ac..ac47522a903a2312ebb906efb2ef55a1356f0810 100644
--- a/Source/bindings/templates/union.h
+++ b/Source/bindings/templates/union.h
@@ -47,15 +47,15 @@ private:
{{member.cpp_type}} m_{{member.cpp_name}};
{% endfor %}
- friend v8::Handle<v8::Value> toV8(const {{container.cpp_class}}&, v8::Handle<v8::Object>, v8::Isolate*);
+ friend v8::Local<v8::Value> toV8(const {{container.cpp_class}}&, v8::Local<v8::Object>, v8::Isolate*);
};
class V8{{container.cpp_class}} final {
public:
- static void toImpl(v8::Isolate*, v8::Handle<v8::Value>, {{container.cpp_class}}&, ExceptionState&);
+ static void toImpl(v8::Isolate*, v8::Local<v8::Value>, {{container.cpp_class}}&, ExceptionState&);
};
-v8::Handle<v8::Value> toV8(const {{container.cpp_class}}&, v8::Handle<v8::Object>, v8::Isolate*);
+v8::Local<v8::Value> toV8(const {{container.cpp_class}}&, v8::Local<v8::Object>, v8::Isolate*);
template <class CallbackInfo>
inline void v8SetReturnValue(const CallbackInfo& callbackInfo, {{container.cpp_class}}& impl)
@@ -65,14 +65,14 @@ inline void v8SetReturnValue(const CallbackInfo& callbackInfo, {{container.cpp_c
template <>
struct NativeValueTraits<{{container.cpp_class}}> {
- static {{container.cpp_class}} nativeValue(const v8::Handle<v8::Value>&, v8::Isolate*, ExceptionState&);
+ static {{container.cpp_class}} nativeValue(const v8::Local<v8::Value>&, v8::Isolate*, ExceptionState&);
};
{% endfor %}
{% for cpp_type in nullable_cpp_types %}
class V8{{cpp_type}}OrNull final {
public:
- static void toImpl(v8::Isolate* isolate, v8::Handle<v8::Value> v8Value, {{cpp_type}}& impl, ExceptionState& exceptionState)
+ static void toImpl(v8::Isolate* isolate, v8::Local<v8::Value> v8Value, {{cpp_type}}& impl, ExceptionState& exceptionState)
{
{# http://heycam.github.io/webidl/#es-union #}
{# 1. null or undefined #}
« no previous file with comments | « no previous file | Source/bindings/templates/union.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698