Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Unified Diff: Source/bindings/templates/callback_interface.h

Issue 803963002: [bindings] Use Local<> in lieu of Handle<> for the callback_interface.h/cpp in templates. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/bindings/templates/callback_interface.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/templates/callback_interface.h
diff --git a/Source/bindings/templates/callback_interface.h b/Source/bindings/templates/callback_interface.h
index 28d72e33463105e58514a3e187fcc20eb342ebae..2b2cb73bb359fb88c9f0057df28758fcb9749a08 100644
--- a/Source/bindings/templates/callback_interface.h
+++ b/Source/bindings/templates/callback_interface.h
@@ -16,7 +16,7 @@ namespace blink {
class {{v8_class}} final : public {{cpp_class}}, public ActiveDOMCallback {
public:
- static {{v8_class}}* create(v8::Handle<v8::Function> callback, ScriptState* scriptState)
+ static {{v8_class}}* create(v8::Local<v8::Function> callback, ScriptState* scriptState)
{
return new {{v8_class}}(callback, scriptState);
}
@@ -27,7 +27,7 @@ public:
virtual {{method.cpp_type}} {{method.name}}({{method.argument_declarations | join(', ')}}) override;
{% endfor %}
private:
- {{v8_class}}(v8::Handle<v8::Function>, ScriptState*);
+ {{v8_class}}(v8::Local<v8::Function>, ScriptState*);
ScopedPersistent<v8::Function> m_callback;
RefPtr<ScriptState> m_scriptState;
« no previous file with comments | « no previous file | Source/bindings/templates/callback_interface.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698