Source/bindings/templates/callback_interface.cpp - Issue 803963002: [bindings] Use Local<> in lieu of Handle<> for the callback_interface.h/cpp in templates.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/templates/callback_interface.cpp

Issue 803963002: [bindings] Use Local<> in lieu of Handle<> for the callback_interface.h/cpp in templates. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/bindings/templates/callback_interface.h ('k') | Source/bindings/tests/results/core/V8TestCallbackInterface.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/templates/callback_interface.cpp

diff --git a/Source/bindings/templates/callback_interface.cpp b/Source/bindings/templates/callback_interface.cpp

index 18e89dee99dbe92abad84ed9c2ca15fd41c53a72..a990e3ac39d1c5a52e42ad355df927c87f401d53 100644

--- a/Source/bindings/templates/callback_interface.cpp

+++ b/Source/bindings/templates/callback_interface.cpp

@@ -14,7 +14,7 @@

namespace blink {

-{{v8_class}}::{{v8_class}}(v8::Handle<v8::Function> callback, ScriptState* scriptState)

+{{v8_class}}::{{v8_class}}(v8::Local<v8::Function> callback, ScriptState* scriptState)

: ActiveDOMCallback(scriptState->executionContext())

, m_scriptState(scriptState)

{

« no previous file with comments | « Source/bindings/templates/callback_interface.h ('k') | Source/bindings/tests/results/core/V8TestCallbackInterface.h » ('j') | no next file with comments »