Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Side by Side Diff: Source/devtools/front_end/SettingsScreen.js

Issue 80383004: DevTools: Show asynchronous call stacks on frontend. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: addressed Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/devtools/front_end/Settings.js ('k') | Source/devtools/front_end/SourcesPanel.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 65 matching lines...) Expand 10 before | Expand all | Expand 10 after
76 } 76 }
77 77
78 /** 78 /**
79 * @param {number} min 79 * @param {number} min
80 * @param {number} max 80 * @param {number} max
81 * @param {string} text 81 * @param {string} text
82 * @return {?string} 82 * @return {?string}
83 */ 83 */
84 WebInspector.SettingsScreen.integerValidator = function(min, max, text) 84 WebInspector.SettingsScreen.integerValidator = function(min, max, text)
85 { 85 {
86 var value = parseInt(text, 10); 86 var value = Number(text);
87 if (isNaN(value)) 87 if (isNaN(value))
88 return "Invalid number format"; 88 return "Invalid number format";
89 if (value < min || value > max) 89 if (value < min || value > max)
90 return "Value is out of range [" + min + ", " + max + "]"; 90 return "Value is out of range [" + min + ", " + max + "]";
91 return null; 91 return null;
92 } 92 }
93 93
94 WebInspector.SettingsScreen.Tabs = { 94 WebInspector.SettingsScreen.Tabs = {
95 General: "general", 95 General: "general",
96 Overrides: "overrides", 96 Overrides: "overrides",
(...skipping 291 matching lines...) Expand 10 before | Expand all | Expand 10 after
388 if (WebInspector.experimentsSettings.frameworksDebuggingSupport.isEnabled()) { 388 if (WebInspector.experimentsSettings.frameworksDebuggingSupport.isEnabled()) {
389 checkbox = WebInspector.SettingsTab.createSettingCheckbox(WebInspector.U IString("Skip stepping through sources with particular names"), WebInspector.set tings.skipStackFramesSwitch); 389 checkbox = WebInspector.SettingsTab.createSettingCheckbox(WebInspector.U IString("Skip stepping through sources with particular names"), WebInspector.set tings.skipStackFramesSwitch);
390 fieldset = WebInspector.SettingsTab.createSettingFieldset(WebInspector.s ettings.skipStackFramesSwitch); 390 fieldset = WebInspector.SettingsTab.createSettingFieldset(WebInspector.s ettings.skipStackFramesSwitch);
391 fieldset.appendChild(this._createInputSetting(WebInspector.UIString("Pat tern"), WebInspector.settings.skipStackFramesPattern, false, 1000, "100px", WebI nspector.SettingsScreen.regexValidator)); 391 fieldset.appendChild(this._createInputSetting(WebInspector.UIString("Pat tern"), WebInspector.settings.skipStackFramesPattern, false, 1000, "100px", WebI nspector.SettingsScreen.regexValidator));
392 checkbox.appendChild(fieldset); 392 checkbox.appendChild(fieldset);
393 p.appendChild(checkbox); 393 p.appendChild(checkbox);
394 } 394 }
395 WebInspector.settings.skipStackFramesSwitch.addChangeListener(this._skipStac kFramesSwitchOrPatternChanged, this); 395 WebInspector.settings.skipStackFramesSwitch.addChangeListener(this._skipStac kFramesSwitchOrPatternChanged, this);
396 WebInspector.settings.skipStackFramesPattern.addChangeListener(this._skipSta ckFramesSwitchOrPatternChanged, this); 396 WebInspector.settings.skipStackFramesPattern.addChangeListener(this._skipSta ckFramesSwitchOrPatternChanged, this);
397 397
398 p.appendChild(WebInspector.SettingsTab.createSettingCheckbox(WebInspector.UI String("Enable async stack traces"), WebInspector.settings.enableAsyncStackTrace s));
399
398 p = this._appendSection(WebInspector.UIString("Profiler")); 400 p = this._appendSection(WebInspector.UIString("Profiler"));
399 p.appendChild(WebInspector.SettingsTab.createSettingCheckbox(WebInspector.UI String("Show advanced heap snapshot properties"), WebInspector.settings.showAdva ncedHeapSnapshotProperties)); 401 p.appendChild(WebInspector.SettingsTab.createSettingCheckbox(WebInspector.UI String("Show advanced heap snapshot properties"), WebInspector.settings.showAdva ncedHeapSnapshotProperties));
400 p.appendChild(WebInspector.SettingsTab.createSettingCheckbox(WebInspector.UI String("High resolution CPU profiling"), WebInspector.settings.highResolutionCpu Profiling)); 402 p.appendChild(WebInspector.SettingsTab.createSettingCheckbox(WebInspector.UI String("High resolution CPU profiling"), WebInspector.settings.highResolutionCpu Profiling));
401 403
402 p = this._appendSection(WebInspector.UIString("Console")); 404 p = this._appendSection(WebInspector.UIString("Console"));
403 p.appendChild(WebInspector.SettingsTab.createSettingCheckbox(WebInspector.UI String("Log XMLHttpRequests"), WebInspector.settings.monitoringXHREnabled)); 405 p.appendChild(WebInspector.SettingsTab.createSettingCheckbox(WebInspector.UI String("Log XMLHttpRequests"), WebInspector.settings.monitoringXHREnabled));
404 p.appendChild(WebInspector.SettingsTab.createSettingCheckbox(WebInspector.UI String("Preserve log upon navigation"), WebInspector.settings.preserveConsoleLog )); 406 p.appendChild(WebInspector.SettingsTab.createSettingCheckbox(WebInspector.UI String("Preserve log upon navigation"), WebInspector.settings.preserveConsoleLog ));
405 407
406 if (WebInspector.extensionServer.hasExtensions()) { 408 if (WebInspector.extensionServer.hasExtensions()) {
407 var handlerSelector = new WebInspector.HandlerSelector(WebInspector.open AnchorLocationRegistry); 409 var handlerSelector = new WebInspector.HandlerSelector(WebInspector.open AnchorLocationRegistry);
(...skipping 740 matching lines...) Expand 10 before | Expand all | Expand 10 after
1148 var columns = this.columns(); 1150 var columns = this.columns();
1149 for (var i = 0; i < columns.length; ++i) { 1151 for (var i = 0; i < columns.length; ++i) {
1150 var columnId = columns[i]; 1152 var columnId = columns[i];
1151 var inputElement = this._addInputElements[columnId]; 1153 var inputElement = this._addInputElements[columnId];
1152 inputElement.value = ""; 1154 inputElement.value = "";
1153 } 1155 }
1154 }, 1156 },
1155 1157
1156 __proto__: WebInspector.SettingsList.prototype 1158 __proto__: WebInspector.SettingsList.prototype
1157 } 1159 }
OLDNEW
« no previous file with comments | « Source/devtools/front_end/Settings.js ('k') | Source/devtools/front_end/SourcesPanel.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698