Refactor ExtensionTabUtil-namespaced functions into their own file.

Refactor ExtensionTabUtil-namespaced functions into their own file.

TEST=none; no functionality has changed.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102958

[miket_OOO, 2011-09-23 22:54:24]

Not as bad as it looks. Just moved some code to make a big file smaller.

[asargent_no_longer_on_chrome, 2011-09-23 23:31:03]

http://codereview.chromium.org/8037005/diff/1/chrome/browser/extensions/exten...
File chrome/browser/extensions/extension_tab_util.h (right):

http://codereview.chromium.org/8037005/diff/1/chrome/browser/extensions/exten...
chrome/browser/extensions/extension_tab_util.h:22: namespace ExtensionTabUtil {
nit: according to the style guide, namespace names should be all lower case (I
guess the current code violated this). Maybe switch to "extension_tab_util"?

http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Namespace_Names

I guess another thing we should do to avoid having the change all the call sites
would be make all the methods static in a ExtensionTabUtil class.

[miket_OOO, 2011-09-24 01:22:20]

Will ping you when I patch the CL.

http://codereview.chromium.org/8037005/diff/1/chrome/browser/extensions/exten...
File chrome/browser/extensions/extension_tab_util.h (right):

http://codereview.chromium.org/8037005/diff/1/chrome/browser/extensions/exten...
chrome/browser/extensions/extension_tab_util.h:22: namespace ExtensionTabUtil {
On 2011/09/23 23:31:03, Antony Sargent wrote:
> nit: according to the style guide, namespace names should be all lower case (I
> guess the current code violated this). Maybe switch to "extension_tab_util"?
> 
> http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Namespace_Names
> 
> I guess another thing we should do to avoid having the change all the call
sites
> would be make all the methods static in a ExtensionTabUtil class. 
> 

From the API consumer's perspective it sure looks like a class. I'll give that a
try and update the CL.

[miket_OOO, 2011-09-26 17:51:48]

Changed to class. Re-running browser_tests now but looks good so far. Please
re-review.

[asargent_no_longer_on_chrome, 2011-09-26 18:55:20]

LGTM

http://codereview.chromium.org/8037005/diff/2002/chrome/browser/automation/au...
File chrome/browser/automation/automation_provider_observers.cc (right):

http://codereview.chromium.org/8037005/diff/2002/chrome/browser/automation/au...
chrome/browser/automation/automation_provider_observers.cc:33: #include
"chrome/browser/extensions/extension_tabs_module.h"
Does this file still need to include extension_tabs_module.h?

(Same question for all the files where you've added extension_tab_util.h)

http://codereview.chromium.org/8037005/diff/2002/chrome/browser/extensions/ex...
File chrome/browser/extensions/extension_tab_util.h (right):

http://codereview.chromium.org/8037005/diff/2002/chrome/browser/extensions/ex...
chrome/browser/extensions/extension_tab_util.h:22: class ExtensionTabUtil {
nit: Probably worth having a brief comment to comply with:

http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Class_Comments

[commit-bot: I haz the power, 2011-09-26 23:47:44]

CQ is trying tha patch. Follow status at
https://chromium-status.appspot.com/cq/miket@chromium.org/8037005/7001

[commit-bot: I haz the power, 2011-09-27 16:10:21]

CQ is trying tha patch. Follow status at
https://chromium-status.appspot.com/cq/miket@chromium.org/8037005/7001

[commit-bot: I haz the power, 2011-09-27 17:26:14]

Change committed as 102958