Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(753)

Unified Diff: chrome/browser/extensions/extension_tabs_module.h

Issue 8037005: Refactor ExtensionTabUtil-namespaced functions into their own file. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Updates after try runs. Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/extension_tab_util.cc ('k') | chrome/browser/extensions/extension_tabs_module.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_tabs_module.h
diff --git a/chrome/browser/extensions/extension_tabs_module.h b/chrome/browser/extensions/extension_tabs_module.h
index 0dd8e3be5727448096cd111bc54c0bd59aec02ea..a248c476ca4f0d1154156798af57384e246c7e3a 100644
--- a/chrome/browser/extensions/extension_tabs_module.h
+++ b/chrome/browser/extensions/extension_tabs_module.h
@@ -15,47 +15,7 @@
#include "content/common/notification_registrar.h"
class BackingStore;
-class Browser;
class SkBitmap;
-class TabContents;
-class TabContentsWrapper;
-class TabStripModel;
-
-namespace base {
-class DictionaryValue;
-class ListValue;
-}
-
-namespace ExtensionTabUtil {
-int GetWindowId(const Browser* browser);
-int GetTabId(const TabContents* tab_contents);
-std::string GetTabStatusText(bool is_loading);
-int GetWindowIdOfTab(const TabContents* tab_contents);
-base::ListValue* CreateTabList(const Browser* browser);
-base::DictionaryValue* CreateTabValue(const TabContents* tab_contents);
-base::DictionaryValue* CreateTabValue(const TabContents* tab_contents,
- TabStripModel* tab_strip,
- int tab_index);
-// Create a tab value, overriding its kSelectedKey to the provided boolean.
-base::DictionaryValue* CreateTabValueActive(const TabContents* tab_contents,
- bool active);
-base::DictionaryValue* CreateWindowValue(const Browser* browser,
- bool populate_tabs);
-// Gets the |tab_strip_model| and |tab_index| for the given |tab_contents|.
-bool GetTabStripModel(const TabContents* tab_contents,
- TabStripModel** tab_strip_model,
- int* tab_index);
-bool GetDefaultTab(Browser* browser,
- TabContentsWrapper** contents,
- int* tab_id);
-// Any out parameter (|browser|, |tab_strip|, |contents|, & |tab_index|) may
-// be NULL and will not be set within the function.
-bool GetTabById(int tab_id, Profile* profile, bool incognito_enabled,
- Browser** browser,
- TabStripModel** tab_strip,
- TabContentsWrapper** contents,
- int* tab_index);
-}
// Windows
class GetWindowFunction : public SyncExtensionFunction {
« no previous file with comments | « chrome/browser/extensions/extension_tab_util.cc ('k') | chrome/browser/extensions/extension_tabs_module.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698