Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3387)

Unified Diff: build/android/test_runner.py

Issue 803643002: Remove hardcoding of appurify address information. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: gitfu Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/android/pylib/remote/device/remote_device_environment.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/test_runner.py
diff --git a/build/android/test_runner.py b/build/android/test_runner.py
index a672273e7d1584ea69268c3327898c9d71b40d55..ea7b112436914669c65ebefa5bbf41684c1ea74c 100755
--- a/build/android/test_runner.py
+++ b/build/android/test_runner.py
@@ -134,11 +134,11 @@ def AddRemoteDeviceOptions(parser):
help=('OS to have on the device.'))
group.add_argument('--results-path', default='',
help=('File path to download results to.'))
- group.add_argument('--api-protocol', default='http',
+ group.add_argument('--api-protocol', default='',
jbudorick 2014/12/12 20:39:35 remove default= and add required=True. You can the
rnephew (Reviews Here) 2014/12/12 20:44:00 Done.
help=('HTTP protocol to use. (http or https)'))
- group.add_argument('--api-address', default='172.22.21.180',
+ group.add_argument('--api-address', default='',
jbudorick 2014/12/12 20:39:35 same
rnephew (Reviews Here) 2014/12/12 20:44:00 Done.
help=('Address to send HTTP requests.'))
- group.add_argument('--api-port', default='80',
+ group.add_argument('--api-port', default='',
jbudorick 2014/12/12 20:39:35 same
rnephew (Reviews Here) 2014/12/12 20:44:00 Done.
help=('Port to send HTTP requests to.'))
group.add_argument('--runner-type', default='',
help=('Type of test to run as.'))
« no previous file with comments | « build/android/pylib/remote/device/remote_device_environment.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698