build/android/test_runner.py - Issue 803643002: Remove hardcoding of appurify address information.

Side by Side Diff: build/android/test_runner.py

Issue 803643002: Remove hardcoding of appurify address information. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: gitfu Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « build/android/pylib/remote/device/remote_device_environment.py ('k') | no next file » | no next file with comments »

OLD	NEW
1 #!/usr/bin/env python	1 #!/usr/bin/env python

2 #	2 #

3 # Copyright 2013 The Chromium Authors. All rights reserved.	3 # Copyright 2013 The Chromium Authors. All rights reserved.

4 # Use of this source code is governed by a BSD-style license that can be	4 # Use of this source code is governed by a BSD-style license that can be

5 # found in the LICENSE file.	5 # found in the LICENSE file.

6	6

7 """Runs all types of tests from one unified interface."""	7 """Runs all types of tests from one unified interface."""

8	8

9 import argparse	9 import argparse

10 import collections	10 import collections

(...skipping 116 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
127 'in given file path. '))	127 'in given file path. '))

128 group.add_argument('--collect', default='',	128 group.add_argument('--collect', default='',

129 help=('Only collects the test results if set. '	129 help=('Only collects the test results if set. '

130 'Gets test_run_id from given file path.'))	130 'Gets test_run_id from given file path.'))

131 group.add_argument('--remote-device', default='Nexus 5',	131 group.add_argument('--remote-device', default='Nexus 5',

132 help=('Device type to run test on.'))	132 help=('Device type to run test on.'))

133 group.add_argument('--remote-device-os', default='4.4.2',	133 group.add_argument('--remote-device-os', default='4.4.2',

134 help=('OS to have on the device.'))	134 help=('OS to have on the device.'))

135 group.add_argument('--results-path', default='',	135 group.add_argument('--results-path', default='',

136 help=('File path to download results to.'))	136 help=('File path to download results to.'))

137 group.add_argument('--api-protocol', default='http',	137 group.add_argument('--api-protocol', default='',
	jbudorick 2014/12/12 20:39:35 remove default= and add required=True. You can the remove default= and add required=True. You can then remove the changes in remote_device_environment. rnephew (Reviews Here) 2014/12/12 20:44:00 Done. Show quoted text On 2014/12/12 20:39:35, jbudorick wrote: > remove default= and add required=True. You can then remove the changes in > remote_device_environment. Done.
138 help=('HTTP protocol to use. (http or https)'))	138 help=('HTTP protocol to use. (http or https)'))

139 group.add_argument('--api-address', default='172.22.21.180',	139 group.add_argument('--api-address', default='',
	jbudorick 2014/12/12 20:39:35 same same rnephew (Reviews Here) 2014/12/12 20:44:00 Done. Show quoted text On 2014/12/12 20:39:35, jbudorick wrote: > same Done.
140 help=('Address to send HTTP requests.'))	140 help=('Address to send HTTP requests.'))

141 group.add_argument('--api-port', default='80',	141 group.add_argument('--api-port', default='',
	jbudorick 2014/12/12 20:39:35 same same rnephew (Reviews Here) 2014/12/12 20:44:00 Done. Show quoted text On 2014/12/12 20:39:35, jbudorick wrote: > same Done.
142 help=('Port to send HTTP requests to.'))	142 help=('Port to send HTTP requests to.'))

143 group.add_argument('--runner-type', default='',	143 group.add_argument('--runner-type', default='',

144 help=('Type of test to run as.'))	144 help=('Type of test to run as.'))

145 group.add_argument('--runner-package', default='',	145 group.add_argument('--runner-package', default='',

146 help=('Package name of test.'))	146 help=('Package name of test.'))

147 group.add_argument('--apk-under-test', default='apks/Chrome.apk',	147 group.add_argument('--apk-under-test', default='apks/Chrome.apk',

148 help=('APK to run tests on.'))	148 help=('APK to run tests on.'))

149	149

150 api_secret_group = group.add_mutually_exclusive_group()	150 api_secret_group = group.add_mutually_exclusive_group()

151 api_secret_group.add_argument('--api-secret', default='',	151 api_secret_group.add_argument('--api-secret', default='',

(...skipping 828 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
980 subparser = command_parsers.add_parser(	980 subparser = command_parsers.add_parser(

981 test_type, usage='%(prog)s [options]', help=config.help_txt)	981 test_type, usage='%(prog)s [options]', help=config.help_txt)

982 config.add_options_func(subparser)	982 config.add_options_func(subparser)

983	983

984 args = parser.parse_args()	984 args = parser.parse_args()

985 return RunTestsCommand(args, parser)	985 return RunTestsCommand(args, parser)

986	986

987	987

988 if __name__ == '__main__':	988 if __name__ == '__main__':

989 sys.exit(main())	989 sys.exit(main())

OLD	NEW