Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Issue 803643002: Remove hardcoding of appurify address information. (Closed)

Created:
6 years ago by rnephew (Reviews Here)
Modified:
6 years ago
Reviewers:
jbudorick
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove hardcoding of appurify address information. Add AMP support to test runner. BUG=428729 Committed: https://crrev.com/7f1e2059f0db3edc339b04c4141051913db2a87f Cr-Commit-Position: refs/heads/master@{#308188}

Patch Set 1 #

Patch Set 2 : gitfu #

Total comments: 6

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -5 lines) Patch
M build/android/pylib/remote/device/remote_device_environment.py View 1 2 3 1 chunk +9 lines, -0 lines 0 comments Download
M build/android/test_runner.py View 1 2 3 4 1 chunk +3 lines, -5 lines 0 comments Download

Messages

Total messages: 15 (4 generated)
rnephew (Reviews Here)
6 years ago (2014-12-12 20:36:46 UTC) #2
jbudorick
https://codereview.chromium.org/803643002/diff/20001/build/android/test_runner.py File build/android/test_runner.py (right): https://codereview.chromium.org/803643002/diff/20001/build/android/test_runner.py#newcode137 build/android/test_runner.py:137: group.add_argument('--api-protocol', default='', remove default= and add required=True. You can ...
6 years ago (2014-12-12 20:39:35 UTC) #3
rnephew (Reviews Here)
https://codereview.chromium.org/803643002/diff/20001/build/android/test_runner.py File build/android/test_runner.py (right): https://codereview.chromium.org/803643002/diff/20001/build/android/test_runner.py#newcode137 build/android/test_runner.py:137: group.add_argument('--api-protocol', default='', On 2014/12/12 20:39:35, jbudorick wrote: > remove ...
6 years ago (2014-12-12 20:44:00 UTC) #4
jbudorick
lgtm
6 years ago (2014-12-12 20:44:53 UTC) #5
jbudorick
On 2014/12/12 20:44:53, jbudorick wrote: > lgtm wait, not lgtm
6 years ago (2014-12-12 20:45:31 UTC) #7
jbudorick
On 2014/12/12 20:45:31, jbudorick wrote: > On 2014/12/12 20:44:53, jbudorick wrote: > > lgtm > ...
6 years ago (2014-12-12 20:46:33 UTC) #9
rnephew (Reviews Here)
Added it back.
6 years ago (2014-12-12 20:52:32 UTC) #10
jbudorick
ok, lgtm
6 years ago (2014-12-12 20:55:06 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/803643002/80001
6 years ago (2014-12-12 20:57:12 UTC) #13
commit-bot: I haz the power
Committed patchset #5 (id:80001)
6 years ago (2014-12-12 23:00:19 UTC) #14
commit-bot: I haz the power
6 years ago (2014-12-12 23:01:00 UTC) #15
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/7f1e2059f0db3edc339b04c4141051913db2a87f
Cr-Commit-Position: refs/heads/master@{#308188}

Powered by Google App Engine
This is Rietveld 408576698