IndexedDB: Reusing leveldb logs when opening database

third_party/leveldatabase/env_chromium.cc

Index: third_party/leveldatabase/env_chromium.cc
diff --git a/third_party/leveldatabase/env_chromium.cc b/third_party/leveldatabase/env_chromium.cc
index cad20412bb343f5abf69b9eb7cc27b6448814e7b..5231f1887e9852fc92661fb393d7612640a419c2 100644
--- a/third_party/leveldatabase/env_chromium.cc
+++ b/third_party/leveldatabase/env_chromium.cc
@@ -358,6 +358,8 @@ const char* MethodIDToString(MethodID method) {
       return "NewRandomAccessFile";
     case kNewWritableFile:
       return "NewWritableFile";
+    case kNewAppendableFile:
+      return "NewAppendableFile";
     case kDeleteFile:
       return "DeleteFile";
     case kCreateDir:
@@ -900,6 +902,23 @@ Status ChromiumEnv::NewWritableFile(const std::string& fname,
   }
 }
 
+Status ChromiumEnv::NewAppendableFile(const std::string& fname,
+                                      leveldb::WritableFile** result) {
+  *result = NULL;
+  FilePath path = FilePath::FromUTF8Unsafe(fname);
+  scoped_ptr<base::File> f(new base::File(
+      path, base::File::FLAG_OPEN_ALWAYS | base::File::FLAG_APPEND));
+  if (!f->IsValid()) {
+    RecordErrorAt(kNewAppendableFile);
+    return MakeIOError(fname, "Unable to create appendable file",
+                       kNewAppendableFile, f->error_details());
+  } else {

[jsbell, 2014/12/15 17:41:23]

No need for else block, since previous returns.

(I know, this was copy/paste from previous NewXXXFile impls)

[cmumford, 2014/12/15 18:08:36]

Done.

+    *result =
+        new ChromiumWritableFile(fname, f.release(), this, this, make_backup_);
+    return Status::OK();
+  }
+}
+
 uint64_t ChromiumEnv::NowMicros() {
   return base::TimeTicks::Now().ToInternalValue();
 }