IndexedDB: Reusing leveldb logs when opening database

third_party/leveldatabase/env_chromium.cc

 // Copyright (c) 2011 The LevelDB Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file. See the AUTHORS file for names of contributors.
 
 #include "third_party/leveldatabase/env_chromium.h"
 
 #if defined(OS_POSIX)
 #include <dirent.h>
 #include <sys/types.h>
 #endif
@@ skipping 340 matching lines @@
     case kWritableFileFlush:
       return "WritableFileFlush";
     case kWritableFileSync:
       return "WritableFileSync";
     case kNewSequentialFile:
       return "NewSequentialFile";
     case kNewRandomAccessFile:
       return "NewRandomAccessFile";
     case kNewWritableFile:
       return "NewWritableFile";
+    case kNewAppendableFile:
+      return "NewAppendableFile";
     case kDeleteFile:
       return "DeleteFile";
     case kCreateDir:
       return "CreateDir";
     case kDeleteDir:
       return "DeleteDir";
     case kGetFileSize:
       return "GetFileSize";
     case kRenameFile:
       return "RenameFile";
@@ skipping 522 matching lines @@
     RecordErrorAt(kNewWritableFile);
     return MakeIOError(fname, "Unable to create writable file",
                        kNewWritableFile, f->error_details());
   } else {
     *result =
         new ChromiumWritableFile(fname, f.release(), this, this, make_backup_);
     return Status::OK();
   }
 }
 
+Status ChromiumEnv::NewAppendableFile(const std::string& fname,
+                                      leveldb::WritableFile** result) {
+  *result = NULL;
+  FilePath path = FilePath::FromUTF8Unsafe(fname);
+  scoped_ptr<base::File> f(new base::File(
+      path, base::File::FLAG_OPEN_ALWAYS | base::File::FLAG_APPEND));
+  if (!f->IsValid()) {
+    RecordErrorAt(kNewAppendableFile);
+    return MakeIOError(fname, "Unable to create appendable file",
+                       kNewAppendableFile, f->error_details());
+  } else {

[jsbell, 2014/12/15 17:41:23]

No need for else block, since previous returns.

(I know, this was copy/paste from previous NewXXXFile impls)

[cmumford, 2014/12/15 18:08:36]

Done.

+    *result =
+        new ChromiumWritableFile(fname, f.release(), this, this, make_backup_);
+    return Status::OK();
+  }
+}
+
 uint64_t ChromiumEnv::NowMicros() {
   return base::TimeTicks::Now().ToInternalValue();
 }
 
 void ChromiumEnv::SleepForMicroseconds(int micros) {
   // Round up to the next millisecond.
   base::PlatformThread::Sleep(base::TimeDelta::FromMicroseconds(micros));
 }
 
 void ChromiumEnv::RecordErrorAt(MethodID method) const {
@@ skipping 173 matching lines @@
 
 Env* IDBEnv() {
   return leveldb_env::idb_env.Pointer();
 }
 
 Env* Env::Default() {
   return leveldb_env::default_env.Pointer();
 }
 
 }  // namespace leveldb