Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(486)

Issue 803523002: Remove a renderer -> browser roundtrip for resolving the showNotification promise. (Closed)

Created:
6 years ago by Peter Beverloo
Modified:
6 years ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@n-rename-params
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove a renderer -> browser roundtrip for resolving the showNotification promise. We always confirm, so we may as well remove the roundtrip together. BUG=432527 Committed: https://crrev.com/5eea7412cff596debc210f374211e5c73ba4fdaf Cr-Commit-Position: refs/heads/master@{#308111}

Patch Set 1 #

Patch Set 2 : remove blank link #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -27 lines) Patch
M content/browser/notifications/notification_message_filter.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/notifications/notification_message_filter.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M content/child/notifications/notification_manager.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/child/notifications/notification_manager.cc View 1 4 chunks +10 lines, -15 lines 0 comments Download
M content/common/platform_notification_messages.h View 2 chunks +1 line, -7 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Michael van Ouwerkerk
lgtm
6 years ago (2014-12-12 14:38:24 UTC) #2
Peter Beverloo
+mkwst -- feeling good enough for some very simple IPC message redness?
6 years ago (2014-12-12 14:39:27 UTC) #4
Mike West
LGTM.
6 years ago (2014-12-12 15:28:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/803523002/20001
6 years ago (2014-12-12 16:28:23 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years ago (2014-12-12 17:36:01 UTC) #8
commit-bot: I haz the power
6 years ago (2014-12-12 17:36:56 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5eea7412cff596debc210f374211e5c73ba4fdaf
Cr-Commit-Position: refs/heads/master@{#308111}

Powered by Google App Engine
This is Rietveld 408576698