content/browser/notifications/notification_message_filter.cc - Issue 803523002: Remove a renderer -> browser roundtrip for resolving the showNotification promise.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/notifications/notification_message_filter.cc

Issue 803523002: Remove a renderer -> browser roundtrip for resolving the showNotification promise. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@n-rename-params

Patch Set: remove blank link Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/notifications/notification_message_filter.h ('k') | content/child/notifications/notification_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/notifications/notification_message_filter.cc

diff --git a/content/browser/notifications/notification_message_filter.cc b/content/browser/notifications/notification_message_filter.cc

index afbebc9e52672507396303e60fff95e773cec73d..537e90a25d1ca56a521b912e50c4acdf35a27a8f 100644

--- a/content/browser/notifications/notification_message_filter.cc

+++ b/content/browser/notifications/notification_message_filter.cc

@@ -101,7 +101,6 @@ void NotificationMessageFilter::OnShowPlatformNotification(

}

void NotificationMessageFilter::OnShowPersistentNotification(

- int request_id,

int64 service_worker_registration_id,

const GURL& origin,

const SkBitmap& icon,

@@ -120,8 +119,6 @@ void NotificationMessageFilter::OnShowPersistentNotification(

icon,

notification_data,

process_id_);

- Send(new PlatformNotificationMsg_DidShowPersistent(request_id));

}

void NotificationMessageFilter::OnClosePlatformNotification(

« no previous file with comments | « content/browser/notifications/notification_message_filter.h ('k') | content/child/notifications/notification_manager.h » ('j') | no next file with comments »