Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 803313003: Rename omaha_client and similar tokens to update_client in all contexts. (Closed)

Created:
5 years, 11 months ago by Sorin Jianu
Modified:
5 years, 11 months ago
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, chromium-apps-reviews_chromium.org, tfarina, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@lkgr
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename omaha_client and similar tokens to update_client in all contexts. This is a mechanical change. The idea here is to refactor the common code involved in installing components and extensions in a common module. In the future, we want more update-related Chrome stuff to go in this module. Therefore, it is desirable that this module have a name that describes its purpose. BUG=445949 Committed: https://crrev.com/39eab2f9d3d0435422f65c6664276fdd72326f89 Cr-Commit-Position: refs/heads/master@{#310022}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : rebase #

Total comments: 2

Patch Set 4 : rebase to master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+360 lines, -709 lines) Patch
M chrome/browser/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/DEPS View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/browser_process_impl.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/component_updater/chrome_component_updater_configurator.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/component_updater/pnacl/pnacl_component_installer.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/extensions/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/runtime/chrome_runtime_api_delegate.cc View 5 chunks +7 lines, -4 lines 0 comments Download
M chrome/browser/extensions/updater/chrome_extension_downloader_factory.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/extensions/updater/extension_updater.cc View 5 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/extensions/updater/extension_updater_unittest.cc View 5 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/extensions/webstore_installer.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/extensions/webstore_installer_unittest.cc View 2 chunks +7 lines, -7 lines 0 comments Download
D chrome/browser/omaha_client/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
D chrome/browser/omaha_client/chrome_omaha_query_params_delegate.h View 1 chunk +0 lines, -35 lines 0 comments Download
D chrome/browser/omaha_client/chrome_omaha_query_params_delegate.cc View 1 chunk +0 lines, -68 lines 0 comments Download
D chrome/browser/omaha_client/chrome_omaha_query_params_delegate_unittest.cc View 1 chunk +0 lines, -51 lines 0 comments Download
M chrome/browser/ui/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/app_list/start_page_handler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A + chrome/browser/update_client/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/browser/update_client/chrome_update_query_params_delegate.h View 1 chunk +37 lines, -0 lines 0 comments Download
A + chrome/browser/update_client/chrome_update_query_params_delegate.cc View 3 chunks +10 lines, -10 lines 0 comments Download
A chrome/browser/update_client/chrome_update_query_params_delegate_unittest.cc View 1 chunk +51 lines, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 4 chunks +3 lines, -3 lines 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M chrome/test/base/chrome_unit_test_suite.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M components/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
M components/component_updater.gypi View 1 chunk +1 line, -1 line 0 comments Download
M components/component_updater/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/component_updater/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M components/component_updater/component_updater_utils.cc View 3 chunks +12 lines, -12 lines 0 comments Download
M components/components.gyp View 2 chunks +1 line, -1 line 0 comments Download
M components/components_tests.gyp View 4 chunks +4 lines, -4 lines 0 comments Download
D components/omaha_client.gypi View 1 chunk +0 lines, -24 lines 0 comments Download
D components/omaha_client/BUILD.gn View 1 chunk +0 lines, -16 lines 0 comments Download
D components/omaha_client/DEPS View 1 chunk +0 lines, -4 lines 0 comments Download
D components/omaha_client/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
D components/omaha_client/omaha_query_params.h View 1 chunk +0 lines, -60 lines 0 comments Download
D components/omaha_client/omaha_query_params.cc View 1 chunk +0 lines, -134 lines 0 comments Download
D components/omaha_client/omaha_query_params_delegate.h View 1 chunk +0 lines, -32 lines 0 comments Download
D components/omaha_client/omaha_query_params_delegate.cc View 1 chunk +0 lines, -15 lines 0 comments Download
D components/omaha_client/omaha_query_params_unittest.cc View 1 chunk +0 lines, -55 lines 0 comments Download
A + components/update_client.gypi View 2 chunks +5 lines, -5 lines 0 comments Download
A + components/update_client/BUILD.gn View 1 2 3 1 chunk +5 lines, -3 lines 0 comments Download
A + components/update_client/DEPS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/update_client/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/update_client/update_query_params.h View 2 chunks +9 lines, -9 lines 0 comments Download
A + components/update_client/update_query_params.cc View 4 chunks +14 lines, -17 lines 0 comments Download
A + components/update_client/update_query_params_delegate.h View 1 chunk +10 lines, -10 lines 0 comments Download
A components/update_client/update_query_params_delegate.cc View 1 chunk +15 lines, -0 lines 0 comments Download
A components/update_client/update_query_params_unittest.cc View 1 chunk +55 lines, -0 lines 0 comments Download
M extensions/browser/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/updater/update_service.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M extensions/browser/updater/update_service_browsertest.cc View 1 5 chunks +10 lines, -9 lines 0 comments Download
M extensions/shell/BUILD.gn View 3 chunks +3 lines, -3 lines 0 comments Download
M extensions/shell/app_shell.gyp View 3 chunks +3 lines, -3 lines 0 comments Download
M extensions/shell/browser/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M extensions/shell/browser/shell_browser_main_parts.h View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/shell/browser/shell_browser_main_parts.cc View 3 chunks +5 lines, -5 lines 0 comments Download
D extensions/shell/browser/shell_omaha_query_params_delegate.h View 1 chunk +0 lines, -26 lines 0 comments Download
D extensions/shell/browser/shell_omaha_query_params_delegate.cc View 1 chunk +0 lines, -22 lines 0 comments Download
A extensions/shell/browser/shell_update_query_params_delegate.h View 1 chunk +28 lines, -0 lines 0 comments Download
A + extensions/shell/browser/shell_update_query_params_delegate.cc View 1 chunk +6 lines, -4 lines 0 comments Download

Messages

Total messages: 20 (6 generated)
Sorin Jianu
Please take a look, thank you!
5 years, 11 months ago (2015-01-03 00:15:40 UTC) #2
waffles
lgtm, thanks!
5 years, 11 months ago (2015-01-05 18:52:42 UTC) #3
Sorin Jianu
I need owner approvals for several files. cpu: please look at everything, since you own ...
5 years, 11 months ago (2015-01-05 19:08:22 UTC) #6
cpu_(ooo_6.6-7.5)
lgtm https://codereview.chromium.org/803313003/diff/40001/components/update_client/BUILD.gn File components/update_client/BUILD.gn (right): https://codereview.chromium.org/803313003/diff/40001/components/update_client/BUILD.gn#newcode11 components/update_client/BUILD.gn:11: ] I must confess I have no idea ...
5 years, 11 months ago (2015-01-05 20:19:03 UTC) #7
Yoyo Zhou
extensions LGTM https://codereview.chromium.org/803313003/diff/40001/components/update_client/BUILD.gn File components/update_client/BUILD.gn (right): https://codereview.chromium.org/803313003/diff/40001/components/update_client/BUILD.gn#newcode11 components/update_client/BUILD.gn:11: ] On 2015/01/05 20:19:03, cpu wrote: > ...
5 years, 11 months ago (2015-01-05 20:21:33 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/803313003/40001
5 years, 11 months ago (2015-01-05 22:06:38 UTC) #10
commit-bot: I haz the power
CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true in order for the CQ ...
5 years, 11 months ago (2015-01-05 22:06:41 UTC) #12
Ken Rockot(use gerrit already)
On 2015/01/05 22:06:41, I haz the power (commit-bot) wrote: > CLs for remote refs other ...
5 years, 11 months ago (2015-01-05 23:10:08 UTC) #13
Ken Rockot(use gerrit already)
On 2015/01/05 22:06:41, I haz the power (commit-bot) wrote: > CLs for remote refs other ...
5 years, 11 months ago (2015-01-05 23:10:08 UTC) #14
Sorin Jianu
Correct, this is the workflow I've been using so far, work off lkgr instead of ...
5 years, 11 months ago (2015-01-05 23:13:05 UTC) #15
Ken Rockot(use gerrit already)
On 2015/01/05 23:13:05, Sorin Jianu wrote: > Correct, this is the workflow I've been using ...
5 years, 11 months ago (2015-01-05 23:17:12 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/803313003/60001
5 years, 11 months ago (2015-01-06 00:20:47 UTC) #18
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 11 months ago (2015-01-06 01:09:37 UTC) #19
commit-bot: I haz the power
5 years, 11 months ago (2015-01-06 01:10:38 UTC) #20
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/39eab2f9d3d0435422f65c6664276fdd72326f89
Cr-Commit-Position: refs/heads/master@{#310022}

Powered by Google App Engine
This is Rietveld 408576698