Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(697)

Unified Diff: components/omaha_client/omaha_query_params_unittest.cc

Issue 803313003: Rename omaha_client and similar tokens to update_client in all contexts. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkgr
Patch Set: rebase to master Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/omaha_client/omaha_query_params_delegate.cc ('k') | components/update_client.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/omaha_client/omaha_query_params_unittest.cc
diff --git a/components/omaha_client/omaha_query_params_unittest.cc b/components/omaha_client/omaha_query_params_unittest.cc
deleted file mode 100644
index f18e46d955ea4f2ca93438a683c6a38a755972c5..0000000000000000000000000000000000000000
--- a/components/omaha_client/omaha_query_params_unittest.cc
+++ /dev/null
@@ -1,55 +0,0 @@
-// Copyright 2014 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "base/strings/stringprintf.h"
-#include "components/omaha_client/omaha_query_params.h"
-#include "components/omaha_client/omaha_query_params_delegate.h"
-#include "testing/gtest/include/gtest/gtest.h"
-
-using base::StringPrintf;
-
-namespace omaha_client {
-
-namespace {
-
-bool Contains(const std::string& source, const std::string& target) {
- return source.find(target) != std::string::npos;
-}
-
-class TestOmahaQueryParamsDelegate : public OmahaQueryParamsDelegate {
- std::string GetExtraParams() override { return "&cat=dog"; }
-};
-
-} // namespace
-
-void TestParams(OmahaQueryParams::ProdId prod_id, bool extra_params) {
- std::string params = OmahaQueryParams::Get(prod_id);
-
- // This doesn't so much test what the values are (since that would be an
- // almost exact duplication of code with omaha_query_params.cc, and wouldn't
- // really test anything) as it is a verification that all the params are
- // present in the generated string.
- EXPECT_TRUE(
- Contains(params, StringPrintf("os=%s", OmahaQueryParams::GetOS())));
- EXPECT_TRUE(
- Contains(params, StringPrintf("arch=%s", OmahaQueryParams::GetArch())));
- EXPECT_TRUE(Contains(
- params,
- StringPrintf("prod=%s", OmahaQueryParams::GetProdIdString(prod_id))));
- if (extra_params)
- EXPECT_TRUE(Contains(params, "cat=dog"));
-}
-
-TEST(OmahaQueryParamsTest, GetParams) {
- TestParams(OmahaQueryParams::CRX, false);
- TestParams(OmahaQueryParams::CHROME, false);
-
- TestOmahaQueryParamsDelegate delegate;
- OmahaQueryParams::SetDelegate(&delegate);
-
- TestParams(OmahaQueryParams::CRX, true);
- TestParams(OmahaQueryParams::CHROME, true);
-}
-
-} // namespace omaha_client
« no previous file with comments | « components/omaha_client/omaha_query_params_delegate.cc ('k') | components/update_client.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698