win: set CXX_LIBRARY_VERSION to 2011

win: set CXX_LIBRARY_VERSION to 2011

Unfortunately VS2013's support of C++11 is partial. It supports the
extended union definition, but does not fully support constexpr.

So, update some locations where CXX_LIBRARY_VERSION is used where
toolchain support is lacking. It works correctly in the locations
where std::is_standard_layout is used.

R=mark@chromium.org
BUG=crashpad:1
Committed: https://chromium.googlesource.com/crashpad/crashpad/+/c23dcdc88a6a39012b16e7f17b20381d393e2351

[Mark Mentovai, 2014-12-15 23:33:19]

https://codereview.chromium.org/803273002/diff/40001/util/stdlib/string_numbe...
File util/stdlib/string_number_conversion.cc (right):

https://codereview.chromium.org/803273002/diff/40001/util/stdlib/string_numbe...
util/stdlib/string_number_conversion.cc:33: #if CXX_LIBRARY_VERSION >= 2011 &&
!defined(COMPILER_MSVC)
Maybe we should do this with a CXX_HAS_CONSTEXPR macro in cxx.h.

[scottmg, 2014-12-15 23:38:19]

https://codereview.chromium.org/803273002/diff/40001/util/stdlib/string_numbe...
File util/stdlib/string_number_conversion.cc (right):

https://codereview.chromium.org/803273002/diff/40001/util/stdlib/string_numbe...
util/stdlib/string_number_conversion.cc:33: #if CXX_LIBRARY_VERSION >= 2011 &&
!defined(COMPILER_MSVC)
On 2014/12/15 23:33:19, Mark Mentovai wrote:
> Maybe we should do this with a CXX_HAS_CONSTEXPR macro in cxx.h.

Done.

[Mark Mentovai, 2014-12-15 23:44:23]

https://codereview.chromium.org/803273002/diff/60001/util/stdlib/cxx.h
File util/stdlib/cxx.h (right):

https://codereview.chromium.org/803273002/diff/60001/util/stdlib/cxx.h#newcode23
util/stdlib/cxx.h:23: #define CXX_HAS_CONSTEXPR 1
I thought you said that MSVC didn’t have constexpr.

[scottmg, 2014-12-15 23:48:38]

https://codereview.chromium.org/803273002/diff/60001/util/stdlib/cxx.h
File util/stdlib/cxx.h (right):

https://codereview.chromium.org/803273002/diff/60001/util/stdlib/cxx.h#newcode23
util/stdlib/cxx.h:23: #define CXX_HAS_CONSTEXPR 1
On 2014/12/15 23:44:23, Mark Mentovai wrote:
> I thought you said that MSVC didn’t have constexpr.

Ugh. :( Fixed, and util/stdlib/string_number_conversion.cc compiles now.

[Mark Mentovai, 2014-12-15 23:51:56]

LGTM with one more small change.

https://codereview.chromium.org/803273002/diff/80001/util/stdlib/string_numbe...
File util/stdlib/string_number_conversion.cc (right):

https://codereview.chromium.org/803273002/diff/80001/util/stdlib/string_numbe...
util/stdlib/string_number_conversion.cc:32: #if CXX_LIBRARY_VERSION >= 2011 &&
CXX_HAS_CONSTEXPR
The way that we’re using this here, it should actually be called
CXX_LIBRARY_HAS_CONSTEXPR. We’re not testing whether the language has constexpr
support, we’re testing whether things in the library are declared constexpr
instead of const.

[scottmg, 2014-12-15 23:54:35]

Patchset #6 (id:100001) has been deleted

[scottmg, 2014-12-15 23:54:48]

Thanks.

https://codereview.chromium.org/803273002/diff/80001/util/stdlib/string_numbe...
File util/stdlib/string_number_conversion.cc (right):

https://codereview.chromium.org/803273002/diff/80001/util/stdlib/string_numbe...
util/stdlib/string_number_conversion.cc:32: #if CXX_LIBRARY_VERSION >= 2011 &&
CXX_HAS_CONSTEXPR
On 2014/12/15 23:51:56, Mark Mentovai wrote:
> The way that we’re using this here, it should actually be called
> CXX_LIBRARY_HAS_CONSTEXPR. We’re not testing whether the language has
constexpr
> support, we’re testing whether things in the library are declared constexpr
> instead of const.

Done.

[scottmg, 2014-12-15 23:55:46]

Committed patchset #6 (id:120001) manually as
c23dcdc88a6a39012b16e7f17b20381d393e2351 (presubmit successful).