win: set CXX_LIBRARY_VERSION to 2011

util/stdlib/string_number_conversion.cc

 // Copyright 2014 The Crashpad Authors. All rights reserved.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
 //
 //     http://www.apache.org/licenses/LICENSE-2.0
 //
 // Unless required by applicable law or agreed to in writing, software
 // distributed under the License is distributed on an "AS IS" BASIS,
@@ skipping 10 matching lines @@
 
 #include <limits>
 
 #include "base/logging.h"
 #include "util/stdlib/cxx.h"
 
 // CONSTEXPR_STATIC_ASSERT will be a normal static_assert if the C++ library is
 // the C++11 library. If using an older C++ library when compiling C++11 code,
 // the std::numeric_limits<>::min() and max() functions will not be marked as
 // constexpr, and thus won’t be usable with C++11’s static_assert(). In that
-// case, a run-time CHECK() will have to do.
-#if CXX_LIBRARY_VERSION >= 2011
+// case, a run-time CHECK() will have to do. Visual Studio is nominally C++11,
+// but does not fully support constexpr, so fall back to a CHECK.
+#if CXX_LIBRARY_VERSION >= 2011 && !defined(COMPILER_MSVC)

[Mark Mentovai, 2014/12/15 23:33:19]

Maybe we should do this with a CXX_HAS_CONSTEXPR macro in cxx.h.

[scottmg, 2014/12/15 23:38:18]

Done.

 #define CONSTEXPR_STATIC_ASSERT(condition, message) \
   static_assert(condition, message)
 #else
 #define CONSTEXPR_STATIC_ASSERT(condition, message) CHECK(condition) << message
 #endif
 
 namespace {
 
 template <typename TIntType, typename TLongType>
 struct StringToIntegerTraits {
@@ skipping 104 matching lines @@
 
 bool StringToNumber(const base::StringPiece& string, int* number) {
   return StringToIntegerInternal<StringToIntTraits>(string, number);
 }
 
 bool StringToNumber(const base::StringPiece& string, unsigned int* number) {
   return StringToIntegerInternal<StringToUnsignedIntTraits>(string, number);
 }
 
 }  // namespace crashpad