Git hash links now go to githug compare view.

Git hash links now go to githug compare view.

Also added in another column for the userid of the release builder.

BUG=skia:

Committed: https://skia.googlesource.com/buildbot/+/8c12d9c6068b8f6a30060af6319fac76a863dd4d

[jcgregorio, 2014-12-15 21:14:11]

jcgregorio@google.com changed reviewers:
+ borenet@google.com

[borenet, 2014-12-16 12:33:34]

LGTM with suggestion.

https://codereview.chromium.org/803243002/diff/1/push/res/imp/server.html
File push/res/imp/server.html (right):

https://codereview.chromium.org/803243002/diff/1/push/res/imp/server.html#new...
push/res/imp/server.html:46: <a
href="https://github.com/google/skia-buildbot/compare/{{p.Hash}}...HEAD">{{p.Hash
| short}}</a>
FWIW this also seems to work:
https://skia.googlesource.com/buildbot/+/HEAD~3..HEAD

https://codereview.chromium.org/803243002/diff/1/push/res/imp/server.html#new...
push/res/imp/server.html:95: },
What's in a user id? If it's an email address, maybe we can be smarter and just
return the part before the '@'?

[jcgregorio, 2014-12-16 12:45:51]

https://codereview.chromium.org/803243002/diff/1/push/res/imp/server.html
File push/res/imp/server.html (right):

https://codereview.chromium.org/803243002/diff/1/push/res/imp/server.html#new...
push/res/imp/server.html:46: <a
href="https://github.com/google/skia-buildbot/compare/{{p.Hash}}...HEAD">{{p.Hash
| short}}</a>
On 2014/12/16 12:33:34, borenet wrote:
> FWIW this also seems to work:
> https://skia.googlesource.com/buildbot/+/HEAD~3..HEAD

Right, but I don't know how far back I am from HEAD, or even what HEAD is on
Github.

https://codereview.chromium.org/803243002/diff/1/push/res/imp/server.html#new...
push/res/imp/server.html:95: },
On 2014/12/16 12:33:34, borenet wrote:
> What's in a user id? If it's an email address, maybe we can be smarter and
just
> return the part before the '@'?

They are just email addresses, but I'm being lazy above and doing formatting by
using a fixed width font so the columns line up :-)

[jcgregorio, 2014-12-16 12:45:52]

The CQ bit was checked by jcgregorio@google.com

[commit-bot: I haz the power, 2014-12-16 12:46:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/803243002/1

[commit-bot: I haz the power, 2014-12-16 12:46:40]

Committed patchset #1 (id:1) as
https://skia.googlesource.com/buildbot/+/8c12d9c6068b8f6a30060af6319fac76a863...

[borenet, 2014-12-16 12:48:33]

https://codereview.chromium.org/803243002/diff/1/push/res/imp/server.html
File push/res/imp/server.html (right):

https://codereview.chromium.org/803243002/diff/1/push/res/imp/server.html#new...
push/res/imp/server.html:46: <a
href="https://github.com/google/skia-buildbot/compare/{{p.Hash}}...HEAD">{{p.Hash
| short}}</a>
On 2014/12/16 12:45:50, jcgregorio wrote:
> On 2014/12/16 12:33:34, borenet wrote:
> > FWIW this also seems to work:
> > https://skia.googlesource.com/buildbot/+/HEAD~3..HEAD
> 
> Right, but I don't know how far back I am from HEAD, or even what HEAD is on
> Github.

That was just an example. You can use any refs.

https://codereview.chromium.org/803243002/diff/1/push/res/imp/server.html#new...
push/res/imp/server.html:95: },
On 2014/12/16 12:45:51, jcgregorio wrote:
> On 2014/12/16 12:33:34, borenet wrote:
> > What's in a user id? If it's an email address, maybe we can be smarter and
> just
> > return the part before the '@'?
> 
> They are just email addresses, but I'm being lazy above and doing formatting
by
> using a fixed width font so the columns line up :-)

SGTM

[jcgregorio, 2014-12-16 12:52:13]

https://codereview.chromium.org/803243002/diff/1/push/res/imp/server.html
File push/res/imp/server.html (right):

https://codereview.chromium.org/803243002/diff/1/push/res/imp/server.html#new...
push/res/imp/server.html:46: <a
href="https://github.com/google/skia-buildbot/compare/{{p.Hash}}...HEAD">{{p.Hash
| short}}</a>
On 2014/12/16 12:48:32, borenet wrote:
> On 2014/12/16 12:45:50, jcgregorio wrote:
> > On 2014/12/16 12:33:34, borenet wrote:
> > > FWIW this also seems to work:
> > > https://skia.googlesource.com/buildbot/+/HEAD~3..HEAD
> > 
> > Right, but I don't know how far back I am from HEAD, or even what HEAD is on
> > Github.
> 
> That was just an example. You can use any refs.

Ah, OK, got it, I thought you we're talking about Github, I completely skipped
over the skia.googlesource.com part of the URL. I actually don't like the
googlesource.com view over a range of commits, the Github view is much better,
giving a rolled up summary of all the commits with the ability to then dive into
more details.