Git hash links now go to githug compare view.

push/res/imp/server.html

Index: push/res/imp/server.html
diff --git a/push/res/imp/server.html b/push/res/imp/server.html
index 699f6dfcd07138b7006d93d81207d3b3e80866b6..0ba68419cad78e4245cc7054e8344d4a75020335 100644
--- a/push/res/imp/server.html
+++ b/push/res/imp/server.html
@@ -27,6 +27,14 @@
   html /deep/ .pushSelection:hover {
     background: #eee;
   }
+  html /deep/ .built {
+    color: #D95F02;
+    display:inline;
+  }
+  html /deep/ .userid {
+    color: #7570B3;
+    display:inline;
+  }
 </style>
 <polymer-element name="push-selection-sk">
   <template>
@@ -35,8 +43,9 @@
         <template repeat="{{p in choices}}">
           <div class=pushSelection name="{{p.Name}}">
             <core-icon icon="{{choice == p.Name ? 'check' : ''}}" title="Currently installed"></core-icon>
-            <a href="https://skia.googlesource.com/buildbot/+/{{p.Hash}}">{{p.Hash | shortHash}}</a>
-            <pre style="color: #D95F02;display:inline;"> {{p.Built | humanDiffDate }} </pre>
+            <a href="https://github.com/google/skia-buildbot/compare/{{p.Hash}}...HEAD">{{p.Hash | short}}</a>

[borenet, 2014/12/16 12:33:34]

FWIW this also seems to work:
https://skia.googlesource.com/buildbot/+/HEAD~3..HEAD

[jcgregorio, 2014/12/16 12:45:50]

Right, but I don't know how far back I am from HEAD, or even what HEAD is on
Github.

[borenet, 2014/12/16 12:48:32]

That was just an example. You can use any refs.

[jcgregorio, 2014/12/16 12:52:13]

Ah, OK, got it, I thought you we're talking about Github, I completely skipped
over the skia.googlesource.com part of the URL. I actually don't like the
googlesource.com view over a range of commits, the Github view is much better,
giving a rolled up summary of all the commits with the ability to then dive into
more details.

+            <pre class=built> {{p.Built | humanDiffDate }} </pre>
+            <pre class=userid title="{{p.UserID}}"> {{p.UserID | short}} </pre>
             {{p.Note}}
             <core-icon icon="{{p.Dirty ? 'warning' : ''}}" title="Uncommited changes when the package was built."></core-icon>
           </div>
@@ -80,8 +89,8 @@
           this.$.chooser.toggle();
         },
 
-        // shortHash is a utility function used in templates to truncate git hashes.
-        shortHash: function(s) {
+        // short is a utility function used in templates to truncate strings.
+        short: function(s) {
           return s.slice(0, 8);
         },

[borenet, 2014/12/16 12:33:34]

What's in a user id? If it's an email address, maybe we can be smarter and just
return the part before the '@'?

[jcgregorio, 2014/12/16 12:45:51]

They are just email addresses, but I'm being lazy above and doing formatting by
using a fixed width font so the columns line up :-)

[borenet, 2014/12/16 12:48:32]

SGTM

 
@@ -204,7 +213,7 @@ Displays the server configurations, along with the ability to modify application
               <paper-button class=application data-server="{{server.Name}}" data-name="{{id}}" data-app="{{id | prefixOf}}"><core-icon icon="create" title="Edit which package is installed."></core-icon></paper-button>
             </td>
             <td><span class=appName>{{id | prefixOf}}</span></td>
-            <td><span class=appName><a href="https://skia.googlesource.com/buildbot/+/{{id | fullHash}}">{{id | shortHash}}</a></span></td>
+            <td><span class=appName><a href="https://github.com/google/skia-buildbot/compare/{{id | fullHash}}...HEAD">{{id | short}}</a></span></td>
             <td><core-icon icon="{{packageLookup[id].Latest ? '' : 'alarm'}}" title="Out of date."></core-icon></td>
             <td><core-icon icon="{{packageLookup[id].Dirty ? 'warning' : ''}}" title="Uncommited changes when the package was built."></core-icon></td>
           </tr>
@@ -300,11 +309,12 @@ Displays the server configurations, along with the ability to modify application
         return s.slice(s.length-44, s.length-4)
       },
 
-      // shortHash is a utility function used in templates to truncate git hashes.
-      shortHash: function(s) {
+      // short is a utility function used in templates to truncate strings.
+      short: function(s) {
         return this.fullHash(s).slice(0, 6);
       },
 
+
     });
   </script>
 </polymer-element>