Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 803153003: Fix rrects that are large enough that we lose/gain a bit when we add the radius to a bounds coordin… (Closed)

Created:
6 years ago by reed1
Modified:
6 years ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix rrects that are large enough that we lose/gain a bit when we add the radius to a bounds coordinate. add test that triggers assert in addRRect BUG=skia:3239 Committed: https://skia.googlesource.com/skia/+/5bcbe91304ec2515208b5218517579f48874e928

Patch Set 1 #

Patch Set 2 : remove dead code #

Total comments: 2

Patch Set 3 : generalize test for all edges and axes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -4 lines) Patch
M include/core/SkPathRef.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/core/SkPath.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/core/SkRRect.cpp View 2 chunks +44 lines, -2 lines 0 comments Download
M tests/PathTest.cpp View 1 2 2 chunks +36 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
reed1
ptal
6 years ago (2014-12-15 18:54:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/803153003/20001
6 years ago (2014-12-15 18:55:59 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years ago (2014-12-15 18:56:00 UTC) #5
robertphillips
lgtm + a testing suggestion https://codereview.chromium.org/803153003/diff/20001/tests/PathTest.cpp File tests/PathTest.cpp (right): https://codereview.chromium.org/803153003/diff/20001/tests/PathTest.cpp#newcode28 tests/PathTest.cpp:28: SkBits2Float(0x4b7f1bd7)); /* 16718807.000000 */ ...
6 years ago (2014-12-15 19:13:21 UTC) #7
reed1
https://codereview.chromium.org/803153003/diff/20001/tests/PathTest.cpp File tests/PathTest.cpp (right): https://codereview.chromium.org/803153003/diff/20001/tests/PathTest.cpp#newcode28 tests/PathTest.cpp:28: SkBits2Float(0x4b7f1bd7)); /* 16718807.000000 */ On 2014/12/15 19:13:21, robertphillips wrote: ...
6 years ago (2014-12-15 19:58:28 UTC) #8
reed1
ptal
6 years ago (2014-12-15 19:58:43 UTC) #9
robertphillips
lgtm
6 years ago (2014-12-15 20:04:01 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/803153003/40001
6 years ago (2014-12-15 20:09:52 UTC) #12
commit-bot: I haz the power
6 years ago (2014-12-15 20:28:37 UTC) #13
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/5bcbe91304ec2515208b5218517579f48874e928

Powered by Google App Engine
This is Rietveld 408576698