Fix rrects that are large enough that we lose/gain a bit when we add the radius to a bounds coordin…

tests/PathTest.cpp

 /*
  * Copyright 2011 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #include "SkCanvas.h"
 #include "SkPaint.h"
 #include "SkParse.h"
 #include "SkParsePath.h"
 #include "SkPath.h"
 #include "SkPathEffect.h"
 #include "SkRRect.h"
 #include "SkRandom.h"
 #include "SkReader32.h"
 #include "SkSize.h"
 #include "SkStream.h"
 #include "SkSurface.h"
 #include "SkTypes.h"
 #include "SkWriter32.h"
 #include "Test.h"
 
+static void test_skbug_3239(skiatest::Reporter* reporter) {
+    const SkRect rect = SkRect::MakeLTRB(SkBits2Float(0xcb7f16c8),  /* -16717512.000000 */
+                                         SkBits2Float(0xcb7f16c8),  /* -16717512.000000 */
+                                         SkBits2Float(0x4b7f1c1d),  /* 16718877.000000 */
+                                         SkBits2Float(0x4b7f1bd7)); /* 16718807.000000 */

[robertphillips, 2014/12/15 19:13:21]

Can we test the four variants having the huge radii in each of the corners?

[reed1, 2014/12/15 19:58:28]

Done.

+    const SkVector radii[] = {
+        { 0, 0 },
+        { 0, 0 },
+        { 0, 0 },
+        { 33436320, 33436320 },
+    };
+    SkRRect rrect;
+    rrect.setRectRadii(rect, radii);
+
+    SkPath path;
+    // this line should not assert in the debug build (from validate)
+    path.addRRect(rrect);
+    REPORTER_ASSERT(reporter, rrect.rect() == path.getBounds());
+}
+
 static void make_path_crbug364224(SkPath* path) {
     path->reset();
     path->moveTo(3.747501373f, 2.724499941f);
     path->lineTo(3.747501373f, 3.75f);
     path->cubicTo(3.747501373f, 3.88774991f, 3.635501385f, 4.0f, 3.497501373f, 4.0f);
     path->lineTo(0.7475013733f, 4.0f);
     path->cubicTo(0.6095013618f, 4.0f, 0.4975013733f, 3.88774991f, 0.4975013733f, 3.75f);
     path->lineTo(0.4975013733f, 1.0f);
     path->cubicTo(0.4975013733f, 0.8622499704f, 0.6095013618f, 0.75f, 0.7475013733f,0.75f);
     path->lineTo(3.497501373f, 0.75f);
@@ skipping 3688 matching lines @@
     test_extendClosedPath(reporter);
     test_addEmptyPath(reporter, SkPath::kExtend_AddPathMode);
     test_addEmptyPath(reporter, SkPath::kAppend_AddPathMode);
     test_conicTo_special_case(reporter);
     test_get_point(reporter);
     test_contains(reporter);
     PathTest_Private::TestPathTo(reporter);
     PathRefTest_Private::TestPathRef(reporter);
     test_dump(reporter);
     test_path_crbugskia2820(reporter);
+    test_skbug_3239(reporter);
 }