Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issue 803113004: Remove containsAttributeSelector() checks. (Closed)

Created:
6 years ago by esprehn
Modified:
6 years ago
Reviewers:
eseidel
CC:
abarth-chromium, mojo-reviews_chromium.org, ojan
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Remove containsAttributeSelector() checks. We can just set the style as unique from inside the SelectorChecker instead. That's not ideal either, but it's simpler, and we'll eventually use a hashing function to instead make elements with attribute selectors that have the same values share their style instead of disabling sharing. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/0997b3f69d49c6259c04c3ffe6b3d658bd17dd81

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -34 lines) Patch
M sky/engine/core/css/ElementRuleCollector.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M sky/engine/core/css/RuleSet.h View 2 chunks +0 lines, -3 lines 0 comments Download
M sky/engine/core/css/RuleSet.cpp View 1 chunk +0 lines, -27 lines 0 comments Download
M sky/engine/core/css/SelectorChecker.cpp View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
esprehn
6 years ago (2014-12-15 21:29:41 UTC) #2
eseidel
lgtm
6 years ago (2014-12-15 21:30:24 UTC) #4
eseidel
Do we need to test this to make sure we're not breaking it?
6 years ago (2014-12-15 21:30:38 UTC) #5
commit-bot: I haz the power
Commit queue rejected this change because it did not recognize the base URL. Please commit ...
6 years ago (2014-12-15 21:32:19 UTC) #7
esprehn
6 years ago (2014-12-15 21:43:44 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0997b3f69d49c6259c04c3ffe6b3d658bd17dd81 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698