Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(422)

Unified Diff: sky/engine/core/css/RuleSet.cpp

Issue 803113004: Remove containsAttributeSelector() checks. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/core/css/RuleSet.h ('k') | sky/engine/core/css/SelectorChecker.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/core/css/RuleSet.cpp
diff --git a/sky/engine/core/css/RuleSet.cpp b/sky/engine/core/css/RuleSet.cpp
index 53e409acf83677cec9c4556ce3130c0cb95a942e..f75b3b4e32201c98fcf5e71e986062ad0f536dd2 100644
--- a/sky/engine/core/css/RuleSet.cpp
+++ b/sky/engine/core/css/RuleSet.cpp
@@ -43,38 +43,11 @@ namespace blink {
// -----------------------------------------------------------------
-// FIXME(sky): Track attribute selectors properly in maps.
-static inline bool selectorListContainsAttributeSelector(const CSSSelector* selector)
-{
- const CSSSelectorList* selectorList = selector->selectorList();
- if (!selectorList)
- return false;
- for (const CSSSelector* selector = selectorList->first(); selector; selector = CSSSelectorList::next(*selector)) {
- for (const CSSSelector* component = selector; component; component = component->tagHistory()) {
- if (component->isAttributeSelector())
- return true;
- }
- }
- return false;
-}
-
-static inline bool containsAttributeSelector(const CSSSelector& selector)
-{
- for (const CSSSelector* current = &selector; current; current = current->tagHistory()) {
- if (current->isAttributeSelector())
- return true;
- if (selectorListContainsAttributeSelector(current))
- return true;
- }
- return false;
-}
-
RuleData::RuleData(StyleRule* rule, unsigned selectorIndex, unsigned position, AddRuleFlags addRuleFlags)
: m_rule(rule)
, m_selectorIndex(selectorIndex)
, m_isLastInArray(false)
, m_position(position)
- , m_containsAttributeSelector(blink::containsAttributeSelector(selector()))
{
ASSERT(m_position == position);
ASSERT(m_selectorIndex == selectorIndex);
« no previous file with comments | « sky/engine/core/css/RuleSet.h ('k') | sky/engine/core/css/SelectorChecker.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698