Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Issue 803063003: Fix crash when passing temporary variable as document/manifest URL. (Closed)

Created:
6 years ago by mlamouri (slow - plz ping)
Modified:
6 years ago
Reviewers:
*Miguel Garcia
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, darin-cc_chromium.org, jam, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix crash when passing temporary variable as document/manifest URL. BUG=366145 Committed: https://crrev.com/0dd6dc969819ef4116a1fdf1a5caad68b7b88c18 Cr-Commit-Position: refs/heads/master@{#308386}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -2 lines) Patch
M content/renderer/manifest/manifest_parser.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/manifest/manifest_parser_unittest.cc View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
mlamouri (slow - plz ping)
6 years ago (2014-12-15 16:52:58 UTC) #3
Miguel Garcia
lgtm
6 years ago (2014-12-15 17:04:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/803063003/1
6 years ago (2014-12-15 17:23:27 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-15 19:13:34 UTC) #7
commit-bot: I haz the power
6 years ago (2014-12-15 19:14:16 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0dd6dc969819ef4116a1fdf1a5caad68b7b88c18
Cr-Commit-Position: refs/heads/master@{#308386}

Powered by Google App Engine
This is Rietveld 408576698