Fix crash when passing temporary variable as document/manifest URL.

content/renderer/manifest/manifest_parser_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/manifest/manifest_parser.h"
 
 #include "base/strings/string_util.h"
 #include "content/public/common/manifest.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
@@ skipping 33 matching lines @@
   std::vector<std::string> errors_;
 
   DISALLOW_COPY_AND_ASSIGN(ManifestParserTest);
 };
 
 const GURL ManifestParserTest::default_document_url(
     "http://foo.com/index.html");
 const GURL ManifestParserTest::default_manifest_url(
     "http://foo.com/manifest.json");
 
+TEST_F(ManifestParserTest, CrashTest) {
+  // Passing temporary variables should not crash.
+  ManifestParser parser("{\"start_url\": \"/\"}",
+                        GURL("http://example.com"),
+                        GURL("http://example.com"));
+  parser.Parse();
+
+  // .Parse() should have been call without crashing and succeeded.
+  EXPECT_EQ(0u, parser.errors().size());
+  EXPECT_FALSE(parser.manifest().IsEmpty());
+}
+
 TEST_F(ManifestParserTest, EmptyStringNull) {
   Manifest manifest = ParseManifest("");
 
   // This Manifest is not a valid JSON object, it's a parsing error.
   EXPECT_EQ(1u, GetErrorCount());
   EXPECT_EQ("Manifest parsing error: Line: 1, column: 1, Unexpected token.",
             errors()[0]);
 
   // A parsing error is equivalent to an empty manifest.
   ASSERT_TRUE(manifest.IsEmpty());
@@ skipping 795 matching lines @@
 
   // "False" should set the boolean false without throwing errors.
   {
     Manifest manifest = ParseManifest("{ \"gcm_user_visible_only\": false }");
     EXPECT_FALSE(manifest.gcm_user_visible_only);
     EXPECT_EQ(0u, GetErrorCount());
   }
 }
 
 } // namespace content