Issue 802833004: Autofill - get rid of one more RenderViewObserver method.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 802833004: Autofill - get rid of one more RenderViewObserver method. (Closed)

Created:
6 years ago by Evan Stade

Modified:
6 years ago

Reviewers:
please use gerrit instead, aurimas (slooooooooow)

CC:
chromium-reviews, mlamouri+watch-content_chromium.org, browser-components-watch_chromium.org, jam, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, estade+watch_chromium.org, rouslan+autofillwatch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Autofill - get rid of one more RenderViewObserver method. BUG=433486

Patch Set 1 #

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+36 lines, -12 lines)			Patch
M	chrome/browser/ui/autofill/chrome_autofill_client.h	View	4 chunks	+13 lines, -1 line	0 comments	Download
M	chrome/browser/ui/autofill/chrome_autofill_client.cc	View	3 chunks	+18 lines, -1 line	0 comments	Download
M	components/autofill/content/renderer/autofill_agent.h	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	components/autofill/content/renderer/autofill_agent.cc	View	2 chunks	+0 lines, -8 lines	0 comments	Download
M	components/autofill/core/browser/autofill_external_delegate.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	components/autofill/core/browser/autofill_manager.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

oops, wrong CL. ignore this.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages