Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Unified Diff: chrome/browser/notifications/message_center_notification_manager.cc

Issue 802753002: Revert of "Call the Close() event on a Notification when it's being replaced." (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/notifications/message_center_notifications_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/notifications/message_center_notification_manager.cc
diff --git a/chrome/browser/notifications/message_center_notification_manager.cc b/chrome/browser/notifications/message_center_notification_manager.cc
index ad4d8de8e642ffbc2491854ecd19be19cc39536f..d99a38b89392a444f52872d1e3c52b08b4a6fa7b 100644
--- a/chrome/browser/notifications/message_center_notification_manager.cc
+++ b/chrome/browser/notifications/message_center_notification_manager.cc
@@ -166,14 +166,6 @@ bool MessageCenterNotificationManager::Update(const Notification& notification,
// the immediate update allowed in the message center.
std::string old_id = old_notification->notification().id();
- // The W3C Web Notifications specification states that replacing a
- // notification should fire the "close" event on the old one. The WHATWG
- // version does not include the "close" event at all anymore, so this
- // will eventually become redundant.
- // TODO(peter): Remove this call when removing the Close() event from
- // Web Notifications. See http://crbug.com/437286.
- old_notification->notification().delegate()->Close(false /* by_user */);
-
// Add/remove notification in the local list but just update the same
// one in MessageCenter.
delete old_notification;
« no previous file with comments | « no previous file | chrome/browser/notifications/message_center_notifications_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698