chrome/browser/notifications/message_center_notifications_browsertest.cc - Issue 802753002: Revert of "Call the Close() event on a Notification when it's being replaced."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/notifications/message_center_notifications_browsertest.cc

Issue 802753002: Revert of "Call the Close() event on a Notification when it's being replaced." (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/notifications/message_center_notification_manager.cc ('k') | chrome/browser/notifications/notification_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/notifications/message_center_notifications_browsertest.cc

diff --git a/chrome/browser/notifications/message_center_notifications_browsertest.cc b/chrome/browser/notifications/message_center_notifications_browsertest.cc

index 7ef2ceb2fb651893b202c80bc9883b75aa16d239..cb97e5af2caa12e2fdc0355f8ce180573ff25197 100644

--- a/chrome/browser/notifications/message_center_notifications_browsertest.cc

+++ b/chrome/browser/notifications/message_center_notifications_browsertest.cc

@@ -212,7 +212,7 @@ IN_PROC_BROWSER_TEST_F(MessageCenterNotificationsTest,

manager()->Add(CreateRichTestNotification("n", &delegate2), profile());

manager()->CancelById("n", NotificationUIManager::GetProfileID(profile()));

- EXPECT_EQ("Display_Close_programmatically_", delegate->log());

+ EXPECT_EQ("Display_", delegate->log());

EXPECT_EQ("Close_programmatically_", delegate2->log());

delegate->Release();