Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(416)

Issue 802753002: Revert of "Call the Close() event on a Notification when it's being replaced." (Closed)

Created:
6 years ago by Peter Beverloo
Modified:
6 years ago
Reviewers:
Jun Mukai
CC:
chromium-reviews, peter+watch_chromium.org, mlamouri+watch-notifications_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of "Call the Close() event on a Notification when it's being replaced." This patch unintentionally also changed behavior of the Chrome Apps Notification API. Revert for now, and figure out whether we should actually want this. BUG=366098, 440256 Committed: https://crrev.com/67c6ae276fa27a8cb47cc221dc487eb55cd3c15e Cr-Commit-Position: refs/heads/master@{#308152}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -39 lines) Patch
M chrome/browser/notifications/message_center_notification_manager.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/browser/notifications/message_center_notifications_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/notifications/notification_browsertest.cc View 2 chunks +4 lines, -13 lines 0 comments Download
M chrome/test/data/notifications/notification_tester.html View 2 chunks +2 lines, -17 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Peter Beverloo
6 years ago (2014-12-12 18:27:05 UTC) #2
Jun Mukai
lgtm. Sorry for this. Next time you may want to write a test case that ...
6 years ago (2014-12-12 18:29:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/802753002/1
6 years ago (2014-12-12 18:32:37 UTC) #5
Peter Beverloo
On 2014/12/12 18:29:01, Jun Mukai wrote: > lgtm. Sorry for this. > > Next time ...
6 years ago (2014-12-12 18:36:09 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-12 20:32:21 UTC) #7
commit-bot: I haz the power
6 years ago (2014-12-12 20:34:07 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/67c6ae276fa27a8cb47cc221dc487eb55cd3c15e
Cr-Commit-Position: refs/heads/master@{#308152}

Powered by Google App Engine
This is Rietveld 408576698