Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 802633007: Upstream iOS UI utilities. (Closed)

Created:
5 years, 11 months ago by droger
Modified:
5 years, 11 months ago
Reviewers:
Nico, sdefresne
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Upstream iOS UI utilities. TBR=thakis Committed: https://crrev.com/72f741a2eaeeb4606b1bfb035afb117b49cd3c84 Cr-Commit-Position: refs/heads/master@{#311284}

Patch Set 1 #

Total comments: 3

Patch Set 2 : Remove rand() #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1811 lines, -0 lines) Patch
M ios/chrome/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
A ios/chrome/browser/ui/animation_util.h View 1 chunk +42 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/animation_util.mm View 1 chunk +94 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/reversed_animation.h View 1 chunk +18 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/reversed_animation.mm View 1 chunk +319 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/snapshots_util.h View 1 chunk +19 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/snapshots_util.mm View 1 chunk +66 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/snapshots_util_unittest.mm View 1 chunk +57 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/ui_util.h View 1 chunk +79 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/ui_util.mm View 1 chunk +149 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/ui_util_unittest.mm View 1 chunk +204 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/uikit_ui_util.h View 1 chunk +141 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/uikit_ui_util.mm View 1 1 chunk +460 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/uikit_ui_util_unittest.mm View 1 1 chunk +141 lines, -0 lines 0 comments Download
M ios/chrome/ios_chrome.gyp View 1 2 chunks +16 lines, -0 lines 0 comments Download
M ios/chrome/ios_chrome_tests.gyp View 1 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
droger
5 years, 11 months ago (2015-01-13 14:45:33 UTC) #2
sdefresne
RSLGTM https://codereview.chromium.org/802633007/diff/1/ios/chrome/browser/ui/uikit_ui_util.mm File ios/chrome/browser/ui/uikit_ui_util.mm (right): https://codereview.chromium.org/802633007/diff/1/ios/chrome/browser/ui/uikit_ui_util.mm#newcode26 ios/chrome/browser/ui/uikit_ui_util.mm:26: // |lerp(a,b,0) == a| and |lerp(a,b,1) == b|. ...
5 years, 11 months ago (2015-01-13 15:19:25 UTC) #3
sdefresne
RubberStampLooksGoodToMe lgtm
5 years, 11 months ago (2015-01-13 15:52:21 UTC) #6
droger
TBR=thakis for the new dependency of //ios/chrome on ocmock
5 years, 11 months ago (2015-01-13 16:00:07 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/802633007/120001
5 years, 11 months ago (2015-01-13 17:34:47 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:120001)
5 years, 11 months ago (2015-01-13 17:35:57 UTC) #14
commit-bot: I haz the power
5 years, 11 months ago (2015-01-13 17:36:38 UTC) #15
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/72f741a2eaeeb4606b1bfb035afb117b49cd3c84
Cr-Commit-Position: refs/heads/master@{#311284}

Powered by Google App Engine
This is Rietveld 408576698