[SVG] Regression: SVG syncbase animation no longer supports cyclic references

Source/core/svg/animation/SVGSMILElement.cpp

Index: Source/core/svg/animation/SVGSMILElement.cpp
diff --git a/Source/core/svg/animation/SVGSMILElement.cpp b/Source/core/svg/animation/SVGSMILElement.cpp
index 68a4933afafb303acb0187d4f9ed8a4ee55903aa..c3037ae7b06a969364cd0200249a6448f18b1e90 100644
--- a/Source/core/svg/animation/SVGSMILElement.cpp
+++ b/Source/core/svg/animation/SVGSMILElement.cpp
@@ -1024,14 +1024,14 @@ void SVGSMILElement::seekToIntervalCorrespondingToTime(SMILTime elapsed)
         if (nextBegin < m_intervalEnd && elapsed >= nextBegin) {
             // End current interval, and start a new interval from the 'nextBegin' time.
             m_intervalEnd = nextBegin;
-            if (!resolveNextInterval(false))
+            if (!resolveNextInterval(true))

[pdr., 2013/11/27 06:57:01]

If we do this, no callers exist with resolveNextInterval(false) and we should
refactor the code to remove that.

But, I don't think these resolveNextInterval(true) calls are right, or I need
more convincing. How did any dependent animation work without passing true here?
For example, how did this work:
<animate id="anim1" begin="0" dur="1s"/>
<animate id="anim2" begin="anim1.end" dur="1s"/>

I worry that this will unnecessarily notify dependents.

[pavane, 2013/11/27 07:41:30]

This code is part of seekToIntervalCorrespondingToTime() which gets called only
if we use setCurrentTime(). I wrote this code to pass the layout tests. If you
observe, there are no layout tests which are using dependent animations till
now. This is first such test case.

The normal path for dependent animations is through checkRestart()which works
pretty well and you will see that it is notifying the dependents that your
interval is changed where as for layout tests, dependent animations doesn't work
because we are not notifying the dependents.

                 break;
             continue;
         }
 
         // If the desired 'elapsed' time is past the current interval, advance to the next.
         if (elapsed >= m_intervalEnd) {
-            if (!resolveNextInterval(false))
+            if (!resolveNextInterval(true))
                 break;
             continue;
         }
@@ -1110,6 +1110,9 @@ bool SVGSMILElement::progress(SMILTime elapsed, SVGSMILElement* resultElement, b
     ASSERT(m_timeContainer);
     ASSERT(m_isWaitingForFirstInterval || m_intervalBegin.isFinite());
 
+    if (!m_conditionsConnected)
+        connectConditions();
+
     if (!m_intervalBegin.isFinite()) {
         ASSERT(m_activeState == Inactive);
         m_nextProgressTime = SMILTime::unresolved();