[SVG] Regression: SVG syncbase animation no longer supports cyclic references

Source/core/svg/animation/SVGSMILElement.cpp

 /*
  * Copyright (C) 2008 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 1006 matching lines @@
 
         // If the 'nextBegin' time is unresolved (eg. just one defined interval), we're done seeking.
         if (nextBegin.isUnresolved())
             return;
 
         // If the 'nextBegin' time is larger than or equal to the current interval end time, we're done seeking.
         // If the 'elapsed' time is smaller than the next begin interval time, we're done seeking.
         if (nextBegin < m_intervalEnd && elapsed >= nextBegin) {
             // End current interval, and start a new interval from the 'nextBegin' time.
             m_intervalEnd = nextBegin;
-            if (!resolveNextInterval(false))
+            if (!resolveNextInterval(true))

[pdr., 2013/11/27 06:57:01]

If we do this, no callers exist with resolveNextInterval(false) and we should
refactor the code to remove that.

But, I don't think these resolveNextInterval(true) calls are right, or I need
more convincing. How did any dependent animation work without passing true here?
For example, how did this work:
<animate id="anim1" begin="0" dur="1s"/>
<animate id="anim2" begin="anim1.end" dur="1s"/>

I worry that this will unnecessarily notify dependents.

[pavane, 2013/11/27 07:41:30]

This code is part of seekToIntervalCorrespondingToTime() which gets called only
if we use setCurrentTime(). I wrote this code to pass the layout tests. If you
observe, there are no layout tests which are using dependent animations till
now. This is first such test case.

The normal path for dependent animations is through checkRestart()which works
pretty well and you will see that it is notifying the dependents that your
interval is changed where as for layout tests, dependent animations doesn't work
because we are not notifying the dependents.

                 break;
             continue;
         }
 
         // If the desired 'elapsed' time is past the current interval, advance to the next.
         if (elapsed >= m_intervalEnd) {
-            if (!resolveNextInterval(false))
+            if (!resolveNextInterval(true))
                 break;
             continue;
         }
 
         return;
     }
 }
 
 float SVGSMILElement::calculateAnimationPercentAndRepeat(SMILTime elapsed, unsigned& repeat) const
 {
@@ skipping 58 matching lines @@
     // Animation does not contribute during the active time if it is past its repeating duration and has fill=remove.
     return (m_activeState == Active && (fill() == FillFreeze || elapsed <= m_intervalBegin + repeatingDuration())) || m_activeState == Frozen;
 }
 
 bool SVGSMILElement::progress(SMILTime elapsed, SVGSMILElement* resultElement, bool seekToTime)
 {
     ASSERT(resultElement);
     ASSERT(m_timeContainer);
     ASSERT(m_isWaitingForFirstInterval || m_intervalBegin.isFinite());
 
+    if (!m_conditionsConnected)
+        connectConditions();
+
     if (!m_intervalBegin.isFinite()) {
         ASSERT(m_activeState == Inactive);
         m_nextProgressTime = SMILTime::unresolved();
         return false;
     }
 
     if (elapsed < m_intervalBegin) {
         ASSERT(m_activeState != Active);
         if (m_activeState == Frozen) {
             if (this == resultElement)
@@ skipping 163 matching lines @@
     if (eventType == "repeatn") {
         unsigned repeatEventCount = m_repeatEventCountList.first();
         m_repeatEventCountList.remove(0);
         dispatchEvent(RepeatEvent::create(eventType, repeatEventCount));
     } else {
         dispatchEvent(Event::create(eventType));
     }
 }
 
 }