Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 8026: Remove WebKeyboardEvent::key_data because we don't actually use it... (Closed)

Created:
12 years, 2 months ago by tony
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Remove WebKeyboardEvent::key_data because we don't actually use it anymore. This makes WebKeyboardEvent easier to port to other platforms. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=3692

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -19 lines) Patch
M chrome/browser/render_view_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/webinputevent.h View 1 chunk +1 line, -3 lines 0 comments Download
M webkit/glue/webinputevent_mac.mm View 1 chunk +0 lines, -1 line 0 comments Download
M webkit/glue/webinputevent_win.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M webkit/glue/webview_impl.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M webkit/tools/test_shell/event_sending_controller.cc View 2 chunks +0 lines, -7 lines 0 comments Download
M webkit/tools/test_shell/keyboard_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
tony
12 years, 2 months ago (2008-10-21 21:07:34 UTC) #1
darin (slow to review)
12 years, 2 months ago (2008-10-21 21:34:38 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698