Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Unified Diff: webkit/tools/test_shell/event_sending_controller.cc

Issue 8026: Remove WebKeyboardEvent::key_data because we don't actually use it... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 12 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/glue/webview_impl.cc ('k') | webkit/tools/test_shell/keyboard_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/tools/test_shell/event_sending_controller.cc
===================================================================
--- webkit/tools/test_shell/event_sending_controller.cc (revision 3671)
+++ webkit/tools/test_shell/event_sending_controller.cc (working copy)
@@ -405,7 +405,6 @@
event_down.type = WebInputEvent::KEY_DOWN;
event_down.modifiers = 0;
event_down.key_code = code;
- event_down.key_data = code;
if (args.size() >= 2 && args[1].isObject())
ApplyKeyModifiers(&(args[1]), &event_down);
@@ -434,30 +433,24 @@
switch(code) {
case '5':
event_char.key_code = kPercentVirtualKeyCode;
- event_char.key_data = kPercentVirtualKeyCode;
break;
case '7':
event_char.key_code = kAmpersandVirtualKeyCode;
- event_char.key_data = kAmpersandVirtualKeyCode;
break;
case '9':
event_char.key_code = kLeftParenthesesVirtualKeyCode;
- event_char.key_data = kLeftParenthesesVirtualKeyCode;
break;
case '0':
event_char.key_code = kRightParenthesesVirtualKeyCode;
- event_char.key_data = kRightParenthesesVirtualKeyCode;
break;
#if defined(OS_WIN)
// '[{' for US
case VK_OEM_4:
event_char.key_code = kLeftCurlyBracketVirtualKeyCode;
- event_char.key_data = kLeftCurlyBracketVirtualKeyCode;
break;
// ']}' for US
case VK_OEM_6:
event_char.key_code = kRightCurlyBracketVirtualKeyCode;
- event_char.key_data = kRightCurlyBracketVirtualKeyCode;
break;
#endif
default:
« no previous file with comments | « webkit/glue/webview_impl.cc ('k') | webkit/tools/test_shell/keyboard_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698