Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(515)

Issue 802583003: [test] Make msan work for v8 stand-alone. (Closed)

Created:
6 years ago by Michael Achenbach
Modified:
5 years, 7 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[test] Make msan work for v8 stand-alone. The msan configuration can be used in combination with v8_use_snapshot=false. BUG=chromium:425187 LOG=n Committed: https://crrev.com/a65ef0d53fc28b0908f228938c6d84effa83c596 Cr-Commit-Position: refs/heads/master@{#28064}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Patch Set 4 : Review #

Patch Set 5 : Fix libc++ path #

Total comments: 1

Patch Set 6 : Rework from scratch #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -0 lines) Patch
M build/standalone.gypi View 1 2 3 4 5 2 chunks +34 lines, -0 lines 3 comments Download

Messages

Total messages: 13 (3 generated)
Sven Panne
lgtm
6 years ago (2014-12-19 12:02:20 UTC) #2
Michael Achenbach
Note: This is blocked on moving libc++.gyp to a common depsable place like buildtools.
6 years ago (2014-12-19 12:17:15 UTC) #3
earthdok
https://codereview.chromium.org/802583003/diff/1/build/standalone.gypi File build/standalone.gypi (right): https://codereview.chromium.org/802583003/diff/1/build/standalone.gypi#newcode222 build/standalone.gypi:222: '-Wl,--as-needed', this should be in "ldflags!", not "ldflags"
6 years ago (2014-12-19 15:54:02 UTC) #4
jochen (gone - plz use gerrit)
https://codereview.chromium.org/802583003/diff/80001/build/standalone.gypi File build/standalone.gypi (left): https://codereview.chromium.org/802583003/diff/80001/build/standalone.gypi#oldcode221 build/standalone.gypi:221: '-fno-omit-frame-pointer', why these changes?
5 years, 11 months ago (2015-01-12 14:23:32 UTC) #5
Michael Achenbach
PTAL at patch 6. This compiles with v8 nosnap builds. https://codereview.chromium.org/802583003/diff/100001/build/standalone.gypi File build/standalone.gypi (right): https://codereview.chromium.org/802583003/diff/100001/build/standalone.gypi#newcode331 ...
5 years, 8 months ago (2015-04-27 09:08:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/802583003/100001
5 years, 8 months ago (2015-04-27 10:12:49 UTC) #9
commit-bot: I haz the power
Committed patchset #6 (id:100001)
5 years, 8 months ago (2015-04-27 10:14:29 UTC) #10
commit-bot: I haz the power
Patchset 6 (id:??) landed as https://crrev.com/a65ef0d53fc28b0908f228938c6d84effa83c596 Cr-Commit-Position: refs/heads/master@{#28064}
5 years, 8 months ago (2015-04-27 10:14:40 UTC) #11
Michael Achenbach
A revert of this CL (patchset #6 id:100001) has been created in https://codereview.chromium.org/1104073002/ by machenbach@chromium.org. ...
5 years, 8 months ago (2015-04-27 11:14:19 UTC) #12
earthdok
5 years, 7 months ago (2015-05-05 14:40:47 UTC) #13
Message was sent while issue was closed.
https://codereview.chromium.org/802583003/diff/100001/build/standalone.gypi
File build/standalone.gypi (right):

https://codereview.chromium.org/802583003/diff/100001/build/standalone.gypi#n...
build/standalone.gypi:41: 'msan_track_origins%': 1,
I suggest '2' here. The performance difference is small enough that we no longer
encourage the use of track_origins=1. We don't have any configurations in
Chromium that use it.

https://codereview.chromium.org/802583003/diff/100001/build/standalone.gypi#n...
build/standalone.gypi:331: 'cflags+': [
On 2015/04/27 09:08:39, Michael Achenbach wrote:
> Without the additional cflags -fPIC and the removal of -fno-exceptions we run
> into compile errors in libc++ and libc++abi.

This is very strange. -fPIC should be implied by -fsanitize=memory, and we
certainly don't need exceptions. Can you paste the errors you see? (or how to
reproduce this)

Powered by Google App Engine
This is Rietveld 408576698