Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2208)

Unified Diff: build/standalone.gypi

Issue 802583003: [test] Make msan work for v8 stand-alone. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Rework from scratch Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/standalone.gypi
diff --git a/build/standalone.gypi b/build/standalone.gypi
index 2266d98346ac094614260105e18df31e69533ed6..cd7847b34979920883063c3f3d622ba495f10b83 100644
--- a/build/standalone.gypi
+++ b/build/standalone.gypi
@@ -35,6 +35,10 @@
'component%': 'static_library',
'clang_dir%': 'third_party/llvm-build/Release+Asserts',
'clang_xcode%': 0,
+ # Track where uninitialized memory originates from. From fastest to
+ # slowest: 0 - no tracking, 1 - track only the initial allocation site, 2
+ # - track the chain of stores leading from allocation site to use site.
+ 'msan_track_origins%': 1,
earthdok 2015/05/05 14:40:47 I suggest '2' here. The performance difference is
'visibility%': 'hidden',
'v8_enable_backtrace%': 0,
'v8_enable_i18n_support%': 1,
@@ -315,6 +319,36 @@
],
},
}],
+ ['msan==1 and OS!="mac"', {
+ 'target_defaults': {
+ 'cflags_cc+': [
+ '-fno-omit-frame-pointer',
+ '-gline-tables-only',
+ '-fsanitize=memory',
+ '-fsanitize-memory-track-origins=<(msan_track_origins)',
+ '-fPIC',
+ ],
+ 'cflags+': [
Michael Achenbach 2015/04/27 09:08:39 Without the additional cflags -fPIC and the remova
earthdok 2015/05/05 14:40:47 This is very strange. -fPIC should be implied by -
+ '-fPIC',
+ ],
+ 'cflags!': [
+ '-fno-exceptions',
+ '-fomit-frame-pointer',
+ ],
+ 'ldflags': [
+ '-fsanitize=memory',
+ ],
+ 'defines': [
+ 'MEMORY_SANITIZER',
+ ],
+ 'dependencies': [
+ # Use libc++ (third_party/libc++ and third_party/libc++abi) instead of
+ # stdlibc++ as standard library. This is intended to use for instrumented
+ # builds.
+ '<(DEPTH)/buildtools/third_party/libc++/libc++.gyp:libcxx_proxy',
+ ],
+ },
+ }],
['asan==1 and OS=="mac"', {
'target_defaults': {
'xcode_settings': {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698