Issue 802573002: Prepare python code for reftests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 802573002: Prepare python code for reftests. (Closed)

Created:
6 years ago by ojan

Modified:
6 years ago

Reviewers:
eseidel

CC:
mojo-reviews_chromium.org, esprehn, abarth-chromium

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Prepare python code for reftests. -s/-expected.html/-expected.sky/ -s/-expected-mismatch.html/-expected-mismatch.sky/ -In single_test_runner.py, get rid of the image hash checking for reftests. It doesn't provide any value and just makes getting reftests working more complicated. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/bbbbe2455059e95584b9ff638a6d5edf1aa9a0b7

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+61 lines, -66 lines)			Patch
M	sky/tests/resources/results.html	View	18 chunks	+26 lines, -26 lines	0 comments	Download
M	sky/tools/webkitpy/layout_tests/controllers/single_test_runner.py	View	2 chunks	+7 lines, -12 lines	0 comments	Download
M	sky/tools/webkitpy/layout_tests/controllers/test_result_writer_unittest.py	View	1 chunk	+6 lines, -6 lines	0 comments	Download
M	sky/tools/webkitpy/layout_tests/models/test_expectations_unittest.py	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	sky/tools/webkitpy/layout_tests/models/test_run_results_unittest.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sky/tools/webkitpy/layout_tests/port/base_unittest.py	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	sky/tools/webkitpy/layout_tests/port/test.py	View	2 chunks	+11 lines, -11 lines	0 comments	Download
M	sky/tools/webkitpy/layout_tests/run_webkit_tests_unittest.py	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	sky/tools/webkitpy/tool/commands/rebaseline_unittest.py	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (2 generated)

ojan

6 years ago (2014-12-11 23:24:07 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
bbbbe2455059e95584b9ff638a6d5edf1aa9a0b7 (presubmit successful).