sky/tools/webkitpy/layout_tests/port/base_unittest.py - Issue 802573002: Prepare python code for reftests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/tools/webkitpy/layout_tests/port/base_unittest.py

Issue 802573002: Prepare python code for reftests. (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/tools/webkitpy/layout_tests/port/base_unittest.py

diff --git a/sky/tools/webkitpy/layout_tests/port/base_unittest.py b/sky/tools/webkitpy/layout_tests/port/base_unittest.py

index 494830d3d112a0eacab0a64d9a5fc7fd3e0a979b..c1f77ebec51475e4de89ec0f25c56cadae5bf32c 100644

--- a/sky/tools/webkitpy/layout_tests/port/base_unittest.py

+++ b/sky/tools/webkitpy/layout_tests/port/base_unittest.py

@@ -287,10 +287,10 @@ class PortTest(unittest.TestCase):

self.assertTrue(Port.is_test_file(filesystem, '', 'foo.svg'))

self.assertTrue(Port.is_test_file(filesystem, '', 'test-ref-test.html'))

self.assertFalse(Port.is_test_file(filesystem, '', 'foo.png'))

- self.assertFalse(Port.is_test_file(filesystem, '', 'foo-expected.html'))

+ self.assertFalse(Port.is_test_file(filesystem, '', 'foo-expected.sky'))

self.assertFalse(Port.is_test_file(filesystem, '', 'foo-expected.svg'))

self.assertFalse(Port.is_test_file(filesystem, '', 'foo-expected.xht'))

- self.assertFalse(Port.is_test_file(filesystem, '', 'foo-expected-mismatch.html'))

+ self.assertFalse(Port.is_test_file(filesystem, '', 'foo-expected-mismatch.sky'))

self.assertFalse(Port.is_test_file(filesystem, '', 'foo-expected-mismatch.svg'))

self.assertFalse(Port.is_test_file(filesystem, '', 'foo-expected-mismatch.xhtml'))

self.assertFalse(Port.is_test_file(filesystem, '', 'foo-ref.html'))

@@ -321,7 +321,7 @@ class PortTest(unittest.TestCase):

def test_reference_files(self):

port = self.make_port(with_tests=True)

self.assertEqual(port.reference_files('passes/svgreftest.svg'), [('==', port.layout_tests_dir() + '/passes/svgreftest-expected.svg')])

- self.assertEqual(port.reference_files('passes/xhtreftest.svg'), [('==', port.layout_tests_dir() + '/passes/xhtreftest-expected.html')])

+ self.assertEqual(port.reference_files('passes/xhtreftest.svg'), [('==', port.layout_tests_dir() + '/passes/xhtreftest-expected.sky')])

self.assertEqual(port.reference_files('passes/phpreftest.php'), [('!=', port.layout_tests_dir() + '/passes/phpreftest-expected-mismatch.svg')])

def test_operating_system(self):