Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1018)

Issue 802453004: Plugin Power Saver: Improve right-click and middle-click behavior. (Closed)

Created:
6 years ago by tommycli
Modified:
6 years ago
Reviewers:
piman
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, darin-cc_chromium.org, jam, mlamouri+watch-content_chromium.org, RyanS, groby-ooo-7-16
Base URL:
https://chromium.googlesource.com/chromium/src.git@0208-plugin-power-saver-fix-black-video-on-resume-problem
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Plugin Power Saver: Improve right-click and middle-click behavior. This patch does two things: a) Prevent right-click from unthrottling plugins. Always passes it straight to the plugin, so the plugin-native context menu can show. This is useful for verifying whether or not something on the page is Flash, for instance. b) Prevents middle-click from unthrottling plugins. Continues to consume middle-clicks while the plugin is throttled. BUG=443406, 403800 Committed: https://crrev.com/9a3381c7761c03a5aba2a7703a759dcc9b8b6d8b Cr-Commit-Position: refs/heads/master@{#309458}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -2 lines) Patch
M content/renderer/pepper/pepper_plugin_instance_throttler.cc View 1 chunk +11 lines, -2 lines 0 comments Download
M content/renderer/pepper/pepper_plugin_instance_throttler_unittest.cc View 2 chunks +25 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
tommycli
piman: PTAL thanks!
6 years ago (2014-12-22 15:48:21 UTC) #2
piman
lgtm
6 years ago (2014-12-22 19:07:28 UTC) #3
tommycli
thank you sir
6 years ago (2014-12-22 19:09:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/802453004/1
6 years ago (2014-12-22 19:09:41 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-22 20:33:37 UTC) #7
commit-bot: I haz the power
6 years ago (2014-12-22 20:34:48 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9a3381c7761c03a5aba2a7703a759dcc9b8b6d8b
Cr-Commit-Position: refs/heads/master@{#309458}

Powered by Google App Engine
This is Rietveld 408576698