Plugin Power Saver: Improve right-click and middle-click behavior.

content/renderer/pepper/pepper_plugin_instance_throttler.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/pepper/pepper_plugin_instance_throttler.h"
 
 #include "base/metrics/histogram.h"
 #include "base/metrics/sparse_histogram.h"
 #include "base/time/time.h"
 #include "content/public/common/content_constants.h"
@@ skipping 145 matching lines @@
     ++consecutive_interesting_frames_;
   else
     consecutive_interesting_frames_ = 0;
 
   if (consecutive_interesting_frames_ >= kMinimumConsecutiveInterestingFrames)
     SetPluginThrottled(true);
 }
 
 bool PepperPluginInstanceThrottler::ConsumeInputEvent(
     const blink::WebInputEvent& event) {
+  // Always allow right-clicks through so users may verify it's a plug-in.
+  // TODO(tommycli): We should instead show a custom context menu (probably
+  // using PluginPlaceholder) so users aren't confused and try to click the
+  // Flash-internal 'Play' menu item. This is a stopgap solution.
+  if (event.modifiers & blink::WebInputEvent::Modifiers::RightButtonDown)
+    return false;
+
   if (!has_been_clicked_ && is_flash_plugin_ &&
-      event.type == blink::WebInputEvent::MouseDown) {
+      event.type == blink::WebInputEvent::MouseDown &&
+      (event.modifiers & blink::WebInputEvent::LeftButtonDown)) {
     has_been_clicked_ = true;
     RecordFlashClickSizeMetric(bounds_.width, bounds_.height);
   }
 
-  if (event.type == blink::WebInputEvent::MouseUp && is_peripheral_content_) {
+  if (is_peripheral_content_ && event.type == blink::WebInputEvent::MouseUp &&
+      (event.modifiers & blink::WebInputEvent::LeftButtonDown)) {
     is_peripheral_content_ = false;
     power_saver_enabled_ = false;
     needs_representative_keyframe_ = false;
 
     RecordUnthrottleMethodMetric(UNTHROTTLE_METHOD_BY_CLICK);
 
     if (plugin_throttled_) {
       SetPluginThrottled(false /* throttled */);
       return true;
     }
@@ skipping 20 matching lines @@
     return;
 
   // Once we change the throttle state, we will never need the snapshot again.
   needs_representative_keyframe_ = false;
 
   plugin_throttled_ = throttled;
   throttle_change_callback_.Run();
 }
 
 }  // namespace content