Handle empty username_hash in ClientCertFilterChromeOS.

Handle empty username_hash in ClientCertFilterChromeOS.

The Init() function did never call back if the username_hash was empty, because GetPrivateSlotForChromeOSUser would return a nullptr and InitIfSlotsAvailable returning consistently false.

Now the callback will be called once GetPrivateSlotForChromeOSUser returned.

This change is on purpose kept minimal to allow merging to M40.

BUG=434205
Committed: https://crrev.com/82065f2b13ce350591d4195b5ee9ff498c2dd31d
Cr-Commit-Position: refs/heads/master@{#308191}

[pneubeck (no reviews), 2014-12-11 18:01:12]

Patchset #1 (id:1) has been deleted

[pneubeck (no reviews), 2014-12-11 18:13:48]

pneubeck@chromium.org changed reviewers:
+ mattm@chromium.org, xiyuan@chromium.org

[pneubeck (no reviews), 2014-12-11 18:13:48]

ptal

[xiyuan, 2014-12-11 18:23:22]

LGTM!

[xiyuan, 2014-12-11 18:31:05]

https://codereview.chromium.org/802433002/diff/20001/chrome/browser/chromeos/...
File chrome/browser/chromeos/net/client_cert_filter_chromeos.cc (right):

https://codereview.chromium.org/802433002/diff/20001/chrome/browser/chromeos/...
chrome/browser/chromeos/net/client_cert_filter_chromeos.cc:36:
waiting_for_private_slot_ = true;
Would the flag needs to be reset when GetPrivateSlotForChromeOSUser works
synchronously?

[pneubeck (no reviews), 2014-12-11 20:25:18]

Patchset #2 (id:40001) has been deleted

[pneubeck (no reviews), 2014-12-11 20:30:26]

Patchset #2 (id:60001) has been deleted

[pneubeck (no reviews), 2014-12-11 20:32:06]

Patchset #2 (id:80001) has been deleted

[pneubeck (no reviews), 2014-12-11 20:32:49]

ptal

https://codereview.chromium.org/802433002/diff/20001/chrome/browser/chromeos/...
File chrome/browser/chromeos/net/client_cert_filter_chromeos.cc (right):

https://codereview.chromium.org/802433002/diff/20001/chrome/browser/chromeos/...
chrome/browser/chromeos/net/client_cert_filter_chromeos.cc:36:
waiting_for_private_slot_ = true;
On 2014/12/11 18:31:05, xiyuan wrote:
> Would the flag needs to be reset when GetPrivateSlotForChromeOSUser works
> synchronously?

of course. you're right.

[xiyuan, 2014-12-11 20:55:21]

LGTM++

[mattm, 2014-12-12 00:03:38]

lgtm

https://codereview.chromium.org/802433002/diff/100001/chrome/browser/chromeos...
File chrome/browser/chromeos/net/client_cert_filter_chromeos.h (right):

https://codereview.chromium.org/802433002/diff/100001/chrome/browser/chromeos...
chrome/browser/chromeos/net/client_cert_filter_chromeos.h:26: // If
|username_hash|, is empty no public and no private slot will be used.
excess comma

[pneubeck (no reviews), 2014-12-12 21:19:37]

The CQ bit was checked by pneubeck@chromium.org

[commit-bot: I haz the power, 2014-12-12 21:21:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/802433002/120001

[commit-bot: I haz the power, 2014-12-12 23:18:34]

Committed patchset #3 (id:120001)

[commit-bot: I haz the power, 2014-12-12 23:19:14]

Patchset 3 (id:??) landed as
https://crrev.com/82065f2b13ce350591d4195b5ee9ff498c2dd31d
Cr-Commit-Position: refs/heads/master@{#308191}