Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3724)

Unified Diff: chrome/browser/chromeos/net/client_cert_filter_chromeos.h

Issue 802433002: Handle empty username_hash in ClientCertFilterChromeOS. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: comment change. Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/chromeos/net/client_cert_filter_chromeos.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/net/client_cert_filter_chromeos.h
diff --git a/chrome/browser/chromeos/net/client_cert_filter_chromeos.h b/chrome/browser/chromeos/net/client_cert_filter_chromeos.h
index 302a8c959c5ca622175e7746d37c532b5a4706ab..048900e42d31b93bf2ddb85b00bb0f5126cf33f9 100644
--- a/chrome/browser/chromeos/net/client_cert_filter_chromeos.h
+++ b/chrome/browser/chromeos/net/client_cert_filter_chromeos.h
@@ -23,6 +23,7 @@ class ClientCertFilterChromeOS
// The internal NSSProfileFilterChromeOS will be initialized with the public
// and private slot of the user with |username_hash| and with the system slot
// if |use_system_slot| is true.
+ // If |username_hash| is empty, no public and no private slot will be used.
ClientCertFilterChromeOS(bool use_system_slot,
const std::string& username_hash);
~ClientCertFilterChromeOS() override;
@@ -64,6 +65,11 @@ class ClientCertFilterChromeOS
// filter is initialized.
crypto::ScopedPK11Slot private_slot_;
+ // If a private slot is requested but the slot, maybe null, is not obtained
+ // yet, this is equal true. As long as this is true, the NSSProfileFilter will
+ // not be initialized.
+ bool waiting_for_private_slot_;
+
net::NSSProfileFilterChromeOS nss_profile_filter_;
base::WeakPtrFactory<ClientCertFilterChromeOS> weak_ptr_factory_;
};
« no previous file with comments | « no previous file | chrome/browser/chromeos/net/client_cert_filter_chromeos.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698