cc/scheduler/scheduler.cc - Issue 802353002: cc: Trigger BeginFrame when children needs it without SetNeedsCommit

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/scheduler/scheduler.cc

Issue 802353002: cc: Trigger BeginFrame when children needs it without SetNeedsCommit (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/scheduler/scheduler.cc

diff --git a/cc/scheduler/scheduler.cc b/cc/scheduler/scheduler.cc

index 143c3ff54489573b1e22bf3a2a35ee17fecb1d95..1eee3e115c3fbc569c66da27ab6a20d1aedc43d6 100644

--- a/cc/scheduler/scheduler.cc

+++ b/cc/scheduler/scheduler.cc

@@ -446,6 +446,7 @@ bool Scheduler::OnBeginFrameMixInDelegate(const BeginFrameArgs& args) {

void Scheduler::SetChildrenNeedBeginFrames(bool children_need_begin_frames) {

DCHECK(settings_.forward_begin_frames_to_children);

state_machine_.SetChildrenNeedBeginFrames(children_need_begin_frames);

+ ProcessScheduledActions();

DCHECK_EQ(state_machine_.NextAction(), SchedulerStateMachine::ACTION_NONE);

brianderson 2014/12/15 20:25:40 lgtm after you delete this DCHECK.

simonhong 2014/12/15 22:34:52 Done.

}

« no previous file with comments | « no previous file | cc/scheduler/scheduler_unittest.cc » ('j') | no next file with comments »