Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Issue 802353002: cc: Trigger BeginFrame when children needs it without SetNeedsCommit (Closed)

Created:
6 years ago by simonhong
Modified:
6 years ago
Reviewers:
brianderson
CC:
chromium-reviews, cc-bugs_chromium.org, scheduler-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Trigger BeginFrame when children needs it without SetNeedsCommit Browser scheduler should trigger BeginFrame when children needs even if it doesn't have a pending commit. R=brianderson@chromium.org BUG=372086 TEST=cc_unittests Committed: https://crrev.com/22c5f0f29d47128966ea3103f6860dfcffcd1bb5 Cr-Commit-Position: refs/heads/master@{#308467}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -2 lines) Patch
M cc/scheduler/scheduler.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M cc/scheduler/scheduler_unittest.cc View 1 chunk +26 lines, -1 line 0 comments Download

Messages

Total messages: 7 (1 generated)
simonhong
PTAL!
6 years ago (2014-12-15 13:27:11 UTC) #1
brianderson
https://codereview.chromium.org/802353002/diff/1/cc/scheduler/scheduler.cc File cc/scheduler/scheduler.cc (right): https://codereview.chromium.org/802353002/diff/1/cc/scheduler/scheduler.cc#newcode450 cc/scheduler/scheduler.cc:450: DCHECK_EQ(state_machine_.NextAction(), SchedulerStateMachine::ACTION_NONE); lgtm after you delete this DCHECK.
6 years ago (2014-12-15 20:25:41 UTC) #2
simonhong
https://codereview.chromium.org/802353002/diff/1/cc/scheduler/scheduler.cc File cc/scheduler/scheduler.cc (right): https://codereview.chromium.org/802353002/diff/1/cc/scheduler/scheduler.cc#newcode450 cc/scheduler/scheduler.cc:450: DCHECK_EQ(state_machine_.NextAction(), SchedulerStateMachine::ACTION_NONE); On 2014/12/15 20:25:40, brianderson wrote: > lgtm ...
6 years ago (2014-12-15 22:34:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/802353002/20001
6 years ago (2014-12-15 22:36:12 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years ago (2014-12-16 00:06:46 UTC) #6
commit-bot: I haz the power
6 years ago (2014-12-16 00:08:37 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/22c5f0f29d47128966ea3103f6860dfcffcd1bb5
Cr-Commit-Position: refs/heads/master@{#308467}

Powered by Google App Engine
This is Rietveld 408576698